OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_76-2101-g6ad3d64
Gerrit Code Review
gerrit@openafs.org
Wed, 18 Jan 2012 09:28:19 -0800 (PST)
The following commit has been merged in the master branch:
commit 6ad3d646e62801cb81a3c9efeac320daa44936e1
Author: Marc Dionne <marc.c.dionne@gmail.com>
Date: Tue Jan 17 20:19:54 2012 -0500
rx: Correctly test for end of call queue
The intention of this condition is to check if the current call
being considered is the last one on the queue, but the test is
incorrect. A null next pointer indicates a removed item, not
the end of the queue.
Use the queue_IsLast macro instead to correctly determine that
this is the last item in the queue and that a call has to be
selected, either the current one or a previously seen good choice.
This can cause calls to get permanently stuck in the call queue
and never get assigned to a thread, even when all threads are
idle.
Change-Id: Ie44a45734ab25bd3d2be3635c2e8f05857ca935e
Reviewed-on: http://gerrit.openafs.org/6564
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
src/rx/rx.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
--
OpenAFS Master Repository