OpenAFS Master Repository branch, openafs-devel-1_7_x, updated. openafs-devel-1_7_4-60-gfbac699

Gerrit Code Review gerrit@openafs.org
Thu, 19 Jan 2012 23:02:40 -0800 (PST)


The following commit has been merged in the openafs-devel-1_7_x branch:
commit fbac699e8ea2cff90a4ce9a5541981fcd90b2abf
Author: Marc Dionne <marc.c.dionne@gmail.com>
Date:   Tue Jan 17 20:19:54 2012 -0500

    rx: Correctly test for end of call queue
    
    The intention of this condition is to check if the current call
    being considered is the last one on the queue, but the test is
    incorrect.  A null next pointer indicates a removed item, not
    the end of the queue.
    
    Use the queue_IsLast macro instead to correctly determine that
    this is the last item in the queue and that a call has to be
    selected, either the current one or a previously seen good choice.
    
    This can cause calls to get permanently stuck in the call queue
    and never get assigned to a thread, even when all threads are
    idle.
    
    Reviewed-on: http://gerrit.openafs.org/6564
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>
    Reviewed-by: Derrick Brashear <shadow@dementix.org>
    (cherry picked from commit 6ad3d646e62801cb81a3c9efeac320daa44936e1)
    
    Change-Id: I8fb51dec8275d6dfd57c28e3dbb5ee69d5624a99
    Reviewed-on: http://gerrit.openafs.org/6582
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>

 src/rx/rx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

-- 
OpenAFS Master Repository