OpenAFS Master Repository branch, openafs-stable-1_6_x, updated. openafs-stable-1_6_1pre1-19-g428400f

Gerrit Code Review
Mon, 23 Jan 2012 18:31:00 -0800 (PST)

The following commit has been merged in the openafs-stable-1_6_x branch:
commit 428400fb831f7b4673973a0d2842ff536b7952c0
Author: Andrew Deason <>
Date:   Fri Jan 13 13:43:16 2012 -0500

    vol: remove SYNC fatal_error processing
    Currently SYNC clients will "disable" themselves on certain error
    patterns. For example, if the server end closes its file descriptor
    too many times, or takes too long and then closes the fd, the SYNC
    client will return an error and set fatal_error. On any subsequent
    SYNC requests, the request will immediately fail without contacting
    the server, often making SYNC client programs effectively useless
    until they are restarted.
    There isn't really any reason to cause future requests to fail.
    Transient problems in the fileserver can easily make this situation
    possible (e.g. a fileserver can crash but still take several minutes
    to close the SYNC fd while the core is written to disk), and so while
    we may return an error for a specific problematic request, future
    requests may be fine.
    So, just remove everything related to fatal_error, so future SYNC
    requests can continue to be attempted. Adjust some log messages to
    reflect the new behavior.
    Tested-by: BuildBot <>
    Reviewed-by: Derrick Brashear <>
    (cherry picked from commit 40bf6dee2409197f7494c3d09bf2dea7c248d185)
    Change-Id: I0f7a1792afd1ace3beabe238107d0a5069ccbb44
    Tested-by: BuildBot <>
    Reviewed-by: Derrick Brashear <>

 src/vol/daemon_com.c      |   12 +++---------
 src/vol/daemon_com.h      |    1 -
 src/vol/fssync-client.c   |    2 +-
 src/vol/salvsync-client.c |    2 +-
 4 files changed, 5 insertions(+), 12 deletions(-)

OpenAFS Master Repository