OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_76-2738-g417df0d

Gerrit Code Review gerrit@openafs.org
Sat, 21 Jul 2012 20:23:41 -0700 (PDT)


The following commit has been merged in the master branch:
commit 417df0d495a8636aec6959b074a35885e20022c9
Author: Garrett Wollman <wollman@csail.mit.edu>
Date:   Sat Jul 21 00:04:58 2012 -0400

    xdr: fix two old FIXMEs related to signed/unsigned arithmetic
    
    It's implementation-defined whether the C '>>' operator, when
    applied to a signed integer, is sign-extending or zero-filling.
    If you want unsigned arithmetic, you have to ask for it explicitly.
    One assumes the reason for the shift is to avoid overflow if the
    returned size/count is later converted to a signed int, in which
    case maybe it would be better to use INT_MAX here.  This is the
    minimal change necessary for correctness.
    
    Change-Id: I6e848110963b5e1832a11d052d84884f10903e2e
    Reviewed-on: http://gerrit.openafs.org/7800
    Reviewed-by: Derrick Brashear <shadow@dementix.org>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>

 src/rx/xdr.c       |    5 ++---
 src/rx/xdr_array.c |    3 +--
 2 files changed, 3 insertions(+), 5 deletions(-)

-- 
OpenAFS Master Repository