OpenAFS Master Repository branch, openafs-devel-1_7_x, updated. openafs-devel-1_7_15-90-g7238618

Gerrit Code Review gerrit@openafs.org
Sat, 21 Jul 2012 21:46:05 -0700 (PDT)


The following commit has been merged in the openafs-devel-1_7_x branch:
commit 72386186bfb742e3e03865025027dff65c6a3c07
Author: Garrett Wollman <wollman@csail.mit.edu>
Date:   Sat Jul 21 00:04:58 2012 -0400

    xdr: fix two old FIXMEs related to signed/unsigned arithmetic
    
    It's implementation-defined whether the C '>>' operator, when
    applied to a signed integer, is sign-extending or zero-filling.
    If you want unsigned arithmetic, you have to ask for it explicitly.
    One assumes the reason for the shift is to avoid overflow if the
    returned size/count is later converted to a signed int, in which
    case maybe it would be better to use INT_MAX here.  This is the
    minimal change necessary for correctness.
    
    Reviewed-on: http://gerrit.openafs.org/7800
    Reviewed-by: Derrick Brashear <shadow@dementix.org>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 417df0d495a8636aec6959b074a35885e20022c9)
    
    Change-Id: I6be50edca3098fb21148c4eaa3cd6a3654eafe6a
    Reviewed-on: http://gerrit.openafs.org/7824
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>

 src/rx/xdr.c       |    5 ++---
 src/rx/xdr_array.c |    3 +--
 2 files changed, 3 insertions(+), 5 deletions(-)

-- 
OpenAFS Master Repository