OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_76-2747-gd3761b9
Gerrit Code Review
gerrit@openafs.org
Sun, 22 Jul 2012 05:23:09 -0700 (PDT)
The following commit has been merged in the master branch:
commit e39d6ca55af79b917e459a09893606e79ba50375
Author: Garrett Wollman <wollman@csail.mit.edu>
Date: Sat Jul 21 01:35:15 2012 -0400
strcompose: NULL must always be cast when passed to a variadic function
The C standard allows NULL to be defined as a bare "0", which will
be passed to variadic functions as an int. If the function expects
a pointer type, demons fly out of your nose. strcompose() is such
a function, so make sure that all of its callers cast NULL appropriately.
(None of them did.) This may be an opportune time to change all of
the callers to spell it opr_strcompose() as well, and avoid using a
reserved identifier, but this change does not do so.
Change-Id: Ia9007a48102da4d0a85a48b41a44e83102304b49
Reviewed-on: http://gerrit.openafs.org/7805
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
src/auth/cellconfig.c | 6 ++++--
src/auth/userok.c | 3 +--
src/auth/writeconfig.c | 4 ++--
src/bozo/fsbnodeops.c | 4 ++--
src/butc/tcmain.c | 6 +++---
src/kauth/kaserver.c | 2 +-
src/ptserver/testpt.c | 6 +++---
src/util/dirpath.c | 8 ++++----
src/vol/daemon_com.c | 2 +-
9 files changed, 21 insertions(+), 20 deletions(-)
--
OpenAFS Master Repository