OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_76-2781-g7649a66
Gerrit Code Review
gerrit@openafs.org
Thu, 26 Jul 2012 10:54:38 -0700 (PDT)
The following commit has been merged in the master branch:
commit 7649a66a6193e2fd8a709bf701fcbb07774d2d33
Author: Garrett Wollman <wollman@csail.mit.edu>
Date: Sun Jul 22 23:20:01 2012 -0400
afs_conn: make release_conns_vector() actually work
release_conns_vector must never have been called before with
a non-null parameter, because it could not possibly work.
The first line of the loop is a null pointer dereference, and
if that were fixed, there's also a modify-after-free bug as well.
It's not clear how what the old version was trying to do; this
version makes a stab at doing something sensible but might be
less than required. (Note that this would be much simpler if
converted to queue(3) macros or a similar standard linked-list
data structure.)
Change-Id: I4c0fb7ed1ee977dcc0b4dfb32557882679069731
Reviewed-on: http://gerrit.openafs.org/7838
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Alistair Ferguson <alistair.ferguson@mac.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
src/afs/afs_conn.c | 12 +++++++-----
1 files changed, 7 insertions(+), 5 deletions(-)
--
OpenAFS Master Repository