OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_76-2609-ge1ff714
Gerrit Code Review
gerrit@openafs.org
Wed, 27 Jun 2012 05:35:38 -0700 (PDT)
The following commit has been merged in the master branch:
commit e1ff7148cce62f7c34614dc1ac1edc909dea1c55
Author: Andrew Deason <adeason@sinenomine.net>
Date: Thu May 24 14:53:59 2012 -0500
cmd: Avoid premature OptionAsString free
Only free the previously-set string value if we're actually going to
change it. This avoids the scenario where a caller does something
like:
char *str = strdup("defaultval");
/* ... */
cmd_OptionAsString(as, OPT_foo, &str);
resulting in 'str' pointing to freed memory when the relevant option
is not specified, or there is some other error.
Change-Id: If1f94d5eb39cc4dba9a4195ff20850ff81737eb9
Reviewed-on: http://gerrit.openafs.org/7475
Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
src/cmd/cmd.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
--
OpenAFS Master Repository