OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_76-2259-g32ad50b

Gerrit Code Review gerrit@openafs.org
Tue, 27 Mar 2012 21:10:17 -0700 (PDT)


The following commit has been merged in the master branch:
commit 32ad50bcee9a5b087bea7e0c9c1cfe3d1e58293e
Author: Jeffrey Altman <jaltman@your-file-system.com>
Date:   Mon Mar 26 11:10:36 2012 -0400

    Windows: AFSInvalidateObject can overwrite input param
    
    AFSInvalidateObject() must not be called with an AFSObjectInformationCB
    pointer variable that it is not safe to overwrite as the function sets
    the input value to NULL if the invalidation is going to be performed
    asynchronously in a worker thread.
    
    In AFSEnumerateDirectory(), the following call took place:
    
      AFSInvalidateObject( &pDirNode->ObjectInformation,
                           AFS_INVALIDATE_DATA_VERSION);
    
    which requires a worker thread to process.  As a result, the
    ObjectInformation pointer was being set to NULL which detached the
    AFSObjectInformationCB from the AFSDirectoryCB.  That in turn produced
    an execption in AFSLocateName() which resulted in a resource not being
    freed that in turn produced a deadlock.
    
    Change-Id: Id30e84cf96b69156d648e3b452e7e03390559c43
    Reviewed-on: http://gerrit.openafs.org/6962
    Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Tested-by: Jeffrey Altman <jaltman@secure-endpoints.com>

 src/WINNT/afsrdr/kernel/lib/AFSCommSupport.cpp |   24 ++++++++++++++++++++++--
 src/WINNT/afsrdr/kernel/lib/AFSGeneric.cpp     |   16 ++++++++++------
 2 files changed, 32 insertions(+), 8 deletions(-)

-- 
OpenAFS Master Repository