OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_76-2542-g9efc255
Gerrit Code Review
gerrit@openafs.org
Thu, 24 May 2012 08:51:49 -0700 (PDT)
The following commit has been merged in the master branch:
commit 8961793dbbae2f8b213372906a281dc38c77186c
Author: Simon Wilkinson <sxw@your-file-system.com>
Date: Wed May 16 20:27:22 2012 +0100
auth: Simplify DNS lookups with asprintf
Instead of allocing a maximal string, and using snprintf to
construct each possible DNS search string, just use asprintf to
construct each string. This greatly simplifies the code, and makes
it much less likely that maths errors can creep in causing buffer
overflows in the future. The downside is that we have more round
trips to the allocator, but that shouldn't matter in this context.
Change-Id: Iae9ab7d45f454c90a937354c71c9ec7fa2c55b69
Reviewed-on: http://gerrit.openafs.org/7452
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
src/auth/cellconfig.c | 30 ++++++++++++------------------
1 files changed, 12 insertions(+), 18 deletions(-)
--
OpenAFS Master Repository