OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_76-3127-gb28c51d

Gerrit Code Review gerrit@openafs.org
Fri, 23 Nov 2012 06:19:43 -0800 (PST)


The following commit has been merged in the master branch:
commit b28c51d594ba3147bc1c30c34b974beb3f1fdfb3
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Wed Nov 21 16:46:29 2012 +0000

    opr: Don't confuse isLast and isEnd
    
    opr_queue_IsEnd's implementation was incorrect - it would return
    true when the element was the last item in the list, not when it
    was the end of the list (equal to the head record)
    
    Correct the implementation of isEnd, and add an implementation for
    isLast.
    
    This fixes a bug in RX, wher we would never notice that the last
    packet in the transmit queue was acknowledged, because the loop that
    iterates over the queue uses isEnd to detect when its work is done.
    
    Change-Id: I8966e05c479c18d025bb5cc4cf77514ce002be95
    Reviewed-on: http://gerrit.openafs.org/8493
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>

 src/opr/queue.h      |    5 +++++
 tests/opr/queues-t.c |   10 +++++++++-
 2 files changed, 14 insertions(+), 1 deletions(-)

-- 
OpenAFS Master Repository