OpenAFS Master Repository branch, openafs-stable-1_6_x, updated. openafs-stable-1_6_1pre2-203-ged8af9f

Gerrit Code Review
Wed, 28 Nov 2012 07:19:37 -0800 (PST)

The following commit has been merged in the openafs-stable-1_6_x branch:
commit ed8af9f7d05c641716e7e281d0c00d06b22b3d27
Author: Andrew Deason <>
Date:   Wed Nov 14 18:29:35 2012 -0600

    afs: Do not skip flushing pages for dv-0 files
    If the dv for a file is 0, we know the file is empty. Currently we
    skip flushing pages for such files, presumably the idea being there is
    no data in the file, so there should be no pages to flush.
    However, Linux seems to keep empty pages around for empty files. So, a
    future read can result in the application reading a page full of
    zeroes, unless we flush the page here. While this has only been found
    to happen on Linux 2.6.22 and later (and distribution-specific
    backports, like RHEL 2.6.18-128), other platforms could in theory also
    choose to do this. It would be difficult to find out when another
    platform started to behave like this, so just remove this skip for
    everyone so we never have to deal with this again.
    Replace this code with a comment with a quick explanation, in case
    anyone tries to add a similar optimization here in the future.
    Thanks to Richard Brittain.
    Reviewed-by: Jeffrey Altman <>
    Tested-by: BuildBot <>
    Reviewed-by: Derrick Brashear <>
    (cherry picked from commit ad4e634051e18fa5bd07016b6405e53e236c2f45)
    Change-Id: I76aed81e0d8acdbf13bc952ac8557b051d2869bf
    Tested-by: BuildBot <>
    Reviewed-by: Andrew Deason <>
    Reviewed-by: Derrick Brashear <>
    Reviewed-by: Jeffrey Altman <>

 src/afs/afs_osi_vm.c |   11 ++++++-----
 1 files changed, 6 insertions(+), 5 deletions(-)

OpenAFS Master Repository