OpenAFS Master Repository branch, openafs-devel-1_7_x, updated. openafs-devel-1_7_19-41-gdb6a274
Gerrit Code Review
gerrit@openafs.org
Thu, 29 Nov 2012 21:49:28 -0800 (PST)
The following commit has been merged in the openafs-devel-1_7_x branch:
commit db6a2740d0fffce33adf65054f59c6e8ccb9a262
Author: Jeffrey Altman <jaltman@your-file-system.com>
Date: Mon Nov 26 11:25:43 2012 -0500
Windows: RefCounts, Asserts, and Trace Logging
Rename DirectoryCB.OpenReferenceCount to DirOpenReferenceCount
to distinguish it from the FCB.OpenReferenceCount. This makes
it easier to search for instances within an editor or debugger.
Ensure that all InterlockedIncrement and InterlockedDecrement
calls on a reference count field assign their value to a local
'lCount' variable. Ensure that 'lCount' is used within any
trace log messages and conditionals.
Add ASSERT( lCount >= 0) after all reference count decrements
in order to catch underflows.
Change conditionals from (RefCount == 0) to (RefCount <= 0) so
that object destruction can occur when there has been an underflow.
This is important in release builds for which ASSERT() is a no-op.
Reviewed-on: http://gerrit.openafs.org/8522
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit b5876a60f7406cdf67a4802b5b6fdf772a303eff)
Change-Id: Ib83ec54316a2358fdc756c9f51b1ca4d82bf4db6
Reviewed-on: http://gerrit.openafs.org/8577
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
src/WINNT/afsrdr/kernel/lib/AFSClose.cpp | 97 +++++------
src/WINNT/afsrdr/kernel/lib/AFSCommSupport.cpp | 22 ++-
src/WINNT/afsrdr/kernel/lib/AFSCreate.cpp | 70 ++++++---
src/WINNT/afsrdr/kernel/lib/AFSDirControl.cpp | 144 ++++++++++++++++--
src/WINNT/afsrdr/kernel/lib/AFSExtentsSupport.cpp | 47 ++++++
src/WINNT/afsrdr/kernel/lib/AFSFcbSupport.cpp | 6 +
src/WINNT/afsrdr/kernel/lib/AFSFileInfo.cpp | 73 ++++++++--
src/WINNT/afsrdr/kernel/lib/AFSGeneric.cpp | 166 ++++++++++++++++----
src/WINNT/afsrdr/kernel/lib/AFSNameSupport.cpp | 137 +++++++++++------
.../kernel/lib/AFSNetworkProviderSupport.cpp | 10 +-
src/WINNT/afsrdr/kernel/lib/AFSWorker.cpp | 8 +-
src/WINNT/afsrdr/kernel/lib/Include/AFSStructs.h | 2 +-
12 files changed, 592 insertions(+), 190 deletions(-)
--
OpenAFS Master Repository