OpenAFS Master Repository branch, openafs-devel-1_7_x, updated. openafs-devel-1_7_21-89-g095a82b
Gerrit Code Review
gerrit@openafs.org
Mon, 11 Feb 2013 22:21:03 -0800 (PST)
The following commit has been merged in the openafs-devel-1_7_x branch:
commit a34be3ec9d8b47db6691641bbb8f4a90a3cdc105
Author: Jeffrey Altman <jaltman@your-file-system.com>
Date: Fri Feb 8 17:28:09 2013 -0500
Windows: AFSLocateNameEntry separate VolumeCB In/Out
Tracking the VolumeCB references within AFSLocateNameEntry has
proven to be very error prone. When the VolumeCB parameter is
an in/out parameter the caller cannot reliably determine whether
or not AFSLocateNameEntry replaced the updated the pointer and
whether it properly released the references. This patchset
changes the interface so that VolumeCB and ParentDirectoryCB
have separate in and out parameters. The caller is now responsible
for tracking its own Volume reference counts and AFSLocateNameEntry
obtains its own which will either be returned to the caller as a
non-NULL OutVolumeCB or released.
This patchset turns ParentDirectoryCB into an IN only parameter
and adds OutParentDirectoryCB as a dedicated OUT parameter. However,
it does not alter any associated reference count logic. That will
be implemented in a subsequent patchset.
Reviewed-on: http://gerrit.openafs.org/9086
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit ef02d3845bedf5daf4628e52d4452ea58eb7909a)
Change-Id: Ia1f110b9cf2ba89f77dd012d74a6f9a1d646a68a
Reviewed-on: http://gerrit.openafs.org/9096
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
src/WINNT/afsrdr/kernel/lib/AFSCreate.cpp | 51 +++++--
src/WINNT/afsrdr/kernel/lib/AFSGeneric.cpp | 154 ++++++++++++--------
src/WINNT/afsrdr/kernel/lib/AFSNameSupport.cpp | 179 ++++++++++++++---------
src/WINNT/afsrdr/kernel/lib/Include/AFSCommon.h | 12 +-
4 files changed, 249 insertions(+), 147 deletions(-)
--
OpenAFS Master Repository