OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_76-3398-g94eb76c
Gerrit Code Review
gerrit@openafs.org
Wed, 20 Feb 2013 10:23:42 -0800 (PST)
The following commit has been merged in the master branch:
commit 1c3492149153ca82b18a36402f7f196f97a8512e
Author: Simon Wilkinson <sxw@your-file-system.com>
Date: Fri Feb 15 17:12:45 2013 +0000
viced: Avoid clang errors with modeBits
The modeBits element of the VnodeDiskObject structure is defined as
a 12 bit wide bitfield. This causes clang some problems when doing
integer arithmetic, as it appears to the compiler that the field is
being overflowed. For example...
targetptr->disk.modeBits &= ~04000;
Produces the error:
implicit truncation from 'int' to bitfield changes value
from -2049 to 2047
Marc Dionne suggested changing this to
targetptr->disk.modeBits = targetptr->disk.modeBits & ~04000;
in order to suppress the clang error.
Change-Id: Iadb53a3db911f5771d3ab2437ccd43abce2a8ecb
Reviewed-on: http://gerrit.openafs.org/9136
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
src/viced/afsfileprocs.c | 12 ++++++++----
1 files changed, 8 insertions(+), 4 deletions(-)
--
OpenAFS Master Repository