OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_76-3535-gce20f1f
Gerrit Code Review
gerrit@openafs.org
Wed, 27 Feb 2013 12:44:46 -0800 (PST)
The following commit has been merged in the master branch:
commit ce20f1f15103226667bc872378cf9b2e4b3e8cd7
Author: Simon Wilkinson <sxw@your-file-system.com>
Date: Wed Feb 27 10:11:21 2013 +0000
libafscp: Can't unlock something we've freed
When we call _StatCleanup on a stored statent structure, it
deletes the mutex, and frees the structure itself. This means it
can't be called with a locked structure as the mutex deletion
will fail, and then we'll try to reference freed memory when we
later unlock that mutex.
Fix this by unlocking the mutex before calling _StatCleanup. This
is safe because the only reference to the structure visible to other
threads must have been deleted by the time we reach this point.
Caught by coverity (#986058, #986059)
Change-Id: I346d4c8a7cd478db044af919662c1cf1c093e205
Reviewed-on: http://gerrit.openafs.org/9297
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
src/libafscp/afscp_fid.c | 14 +++++++++-----
1 files changed, 9 insertions(+), 5 deletions(-)
--
OpenAFS Master Repository