OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_76-3300-gc0627f8
Gerrit Code Review
gerrit@openafs.org
Thu, 31 Jan 2013 11:26:26 -0800 (PST)
The following commit has been merged in the master branch:
commit c0627f8620594191ce5901937175c5f1a93daec2
Author: Jeffrey Altman <jaltman@your-file-system.com>
Date: Sat Dec 29 00:57:31 2012 -0500
Windows: DirOpenReferenceCount reorganizing completed
This patchset completes the reorganizing of the DirOpenReferenceCount
handling. Now that every AFSCcb is given a refCount in AFSInitCcb()
which is released in AFSRemoveCcb() it is possible to simplify some
of the logic surrounding DirOpenReferenceCount handling across
the AFSCommonCreate -> XXX -> AFSLocateNameEntry -> {MountPoint, Symlink}
call sequences.
Wherever possible releasing of DirOpenReferenceCounts occur in a
functions try_exit block. AFSCommonCreate() uses the new variables
bReleaseDir and bReleaseParentDir to track whether these refcounts
need to be released. Additional comments document the decision
making.
There was at least one code path in AFSLocateNameEntry() where
the DirOpenReferenceCount could be dropped when it should not have
been. (pExistingDirNode == pDirNode).
Change-Id: I266a902ad4c44b4b8e49258c2da4acd2df1f4476
Reviewed-on: http://gerrit.openafs.org/8860
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
src/WINNT/afsrdr/kernel/lib/AFSCreate.cpp | 373 +++++++-------------
src/WINNT/afsrdr/kernel/lib/AFSDirControl.cpp | 208 +++--------
src/WINNT/afsrdr/kernel/lib/AFSGeneric.cpp | 5 +-
src/WINNT/afsrdr/kernel/lib/AFSNameSupport.cpp | 112 +++----
.../kernel/lib/AFSNetworkProviderSupport.cpp | 5 +
5 files changed, 247 insertions(+), 456 deletions(-)
--
OpenAFS Master Repository