OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_76-3558-g30e25c7

Gerrit Code Review gerrit@openafs.org
Sun, 3 Mar 2013 19:01:52 -0800 (PST)


The following commit has been merged in the master branch:
commit c0fba6eab519bd1bb6929b788361219f97da7212
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Fri Mar 1 11:09:04 2013 +0000

    bucoord: Remove theoretical overflow of ubik array
    
    The ubik connections array is NULL terminated, so we have to
    ensure that there is enough space for the trailing NULL. As the
    array is MAXSERVERS elements long, this means that we can only
    store MAXSERVERS-1 connections in it.
    
    This problem will never be encountered by the correct code, as
    the number of hosts returned from afsconf_Open is capped at
    MAXHOSTSPERCELL (currently 8). MAXSERVERS is currently 20. However,
    fix the bug in case we increase MAXHOSTSPERCELL at some point in
    the future.
    
    Caught by coverity (#985576)
    
    Change-Id: Icd3f4afe929cbf05522e44132f055a3955c4d23c
    Reviewed-on: http://gerrit.openafs.org/9322
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>

 src/bucoord/ubik_db_if.c |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

-- 
OpenAFS Master Repository