OpenAFS Master Repository branch, openafs-stable-1_6_x, updated. openafs-stable-1_6_2-28-g0c1815b
Gerrit Code Review
gerrit@openafs.org
Fri, 22 Mar 2013 06:02:44 -0700 (PDT)
The following commit has been merged in the openafs-stable-1_6_x branch:
commit 0c1815b37a27a609892a553005da2305a5779a1e
Author: Simon Wilkinson <sxw@your-file-system.com>
Date: Thu Feb 28 15:26:15 2013 +0000
Unix CM: Fix hash table overflow in dnlc code
In GetMeAnEntry, we can end up overflowing the nameHash array by one
element if the stars are particularly badly aligned.
nameptr is a static across function calls, so nameptr and j are not
equal. If nameptr is increment to NHSIZE in the same loop iteration
as j reaches NHSIZE + 2, the loop will terminate. We'll then
lookup nameHash[NHSIZE], which is 1 element passed the end of the
array.
Add an if statement which loops nameptr outside the loop (in the
same way as the if statement in the loop)
Caught by coverity (#985568)
Reviewed-on: http://gerrit.openafs.org/9312
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit d2437d02a6f59d972dd0690f7eb1c46cf7cc4b85)
Change-Id: Ic19d72e6c012cb06e98c3c970162995e77da4b68
Reviewed-on: http://gerrit.openafs.org/9376
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Paul Smeddle <paul.smeddle@gmail.com>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
src/afs/afs_osidnlc.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
--
OpenAFS Master Repository