OpenAFS Master Repository branch, openafs-stable-1_6_x, updated. openafs-stable-1_6_2-74-gae7ea14

Gerrit Code Review gerrit@openafs.org
Tue, 26 Mar 2013 04:39:53 -0700 (PDT)


The following commit has been merged in the openafs-stable-1_6_x branch:
commit ae7ea148390fb2b41bfa7437e97ea55a099abb5f
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Fri Feb 22 16:54:17 2013 +0000

    Unix CM: Fix byte accounting for storebehind
    
    In the current version of CacheStoreDCaches, the stored variable is
    maintained within the for loop that iterates over the chunk list. This
    means that it is reset to 0 each time we handle a new chunk.
    
    However, this means that our progress is no longer accurately tracked,
    as (bytes - stored) no longer gives the number of bytes which remain to
    be transfered. In fact, as stored is zeroed with each loop iteration,
    (bytes - stored) == bytes. This means that store behind is no longer
    activated according to the users settings.
    
    Prior to commit 334114ac58b0039ae90d7e29fa2f019fe068bd79, the
    stored variable was maintained within the outer, function, scope.
    Just move it back there to restore the previous behaviour.
    
    Caught by clang-analyzer
    
    Reviewed-on: http://gerrit.openafs.org/9237
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    (cherry picked from commit 5acb1a0f323a6692cca66ee3aa4c7e5f1a0f24f2)
    
    Change-Id: I22c60b07ba9518d5714c65b1952a35214f690433
    Reviewed-on: http://gerrit.openafs.org/9530
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

 src/afs/afs_fetchstore.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

-- 
OpenAFS Master Repository