OpenAFS Master Repository branch, openafs-stable-1_6_x, updated. openafs-stable-1_6_2-87-g3b26eb7

[Gerrit Code Review]

The following commit has been merged in the openafs-stable-1_6_x branch:
commit 3b26eb76a37fb858672d2bb59589086d230d7959
Author: Andrew Deason <adeason@sinenomine.net>
Date:   Fri Dec 28 12:58:33 2012 -0500

    viced: Avoid dangling uuid hash table entry
    
    Currently we add a given host to the uuid hash table, then call
    RXAFS_InitCallBackState3, and then only initialize the host->interface
    structure if the ICBS3 call succeeded.
    
    If the ICBS3 call fails, we have added a host to the uuid hash table,
    but the host structure does not contain that uuid. If the host is then
    deleted, we will not remove the host from the uuid hash table (since
    host->interface is NULL), and so the uuid hash table entry will still
    point to the freed host. If that host is then later looked up via that
    uuid, we can reference a freed host, which can cause all kinds of
    undefined behavior.
    
    So instead, add the host to the uuid hash table at the same time that
    we initialize the host->interface structure, inside
    initInterfaceAddr_r.
    
    FIXES 131277
    
    Reviewed-on: http://gerrit.openafs.org/8846
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    (cherry picked from commit 7b642173c7cd7b6b7130214c1a940501736abbf0)
    
    Change-Id: I838b55244a9745dd07b7d633cb3091414162b0d5
    Reviewed-on: http://gerrit.openafs.org/8868
    Tested-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: Derrick Brashear <shadow@your-file-system.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

 src/viced/host.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

-- 
OpenAFS Master Repository