OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_76-3764-gc42912d

Gerrit Code Review gerrit@openafs.org
Sat, 11 May 2013 08:09:34 -0700 (PDT)


The following commit has been merged in the master branch:
commit c42912d6da6ff7536b1301b4fb7f556513e8692c
Author: Jeffrey Altman <jaltman@your-file-system.com>
Date:   Thu May 9 21:48:16 2013 -0400

    Windows: AFSCleanup move CCb access inside try block
    
    A crash dump was examined which showed a deadlock due to the leak
    of a SectionObjectResource in a code path in which the holding thread
    could not have obtained it.  The FileObject->FsContext2 (Ccb) pointer
    referred to invalid memory which may have been due to pool corruption.
    The only code path in which the SectionObjectResource is held exclusive
    and then the Ccb pointer is used outside of a try-except block is in
    AFSCleanup().  Move this reference inside the try-except block just in
    case.  If the Ccb is invalid, at least this way AFSRedirLib will catch
    the exception and free the SectionObjectResource before continuing.
    
    Change-Id: I08c9baacfc8897ae8d8b551a74976daf7effbcef
    Reviewed-on: http://gerrit.openafs.org/9892
    Reviewed-by: Peter Scott <pscott@kerneldrivers.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>

 src/WINNT/afsrdr/kernel/lib/AFSCleanup.cpp |   56 +++++++++++++--------------
 1 files changed, 27 insertions(+), 29 deletions(-)

-- 
OpenAFS Master Repository