OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_76-3777-g7cca447

[Gerrit Code Review]

The following commit has been merged in the master branch:
commit 7cca447e2343ccce9b36a3ebe9df1375882a9c34
Author: Andrew Deason <adeason@sinenomine.net>
Date:   Mon May 13 15:33:42 2013 -0500

    DAFS: Avoid useless attach2 error message
    
    Since commit 53230846a202a50f6c3a61b38d62ccba8876f89d, attach2 logs an
    error when we force a volume to an error state due to attachment
    errors. This is to ensure that we never end up with a volume in an
    error state without logging a message about it.
    
    However, while this is useful for the fileserver, for non-fileserver
    programs this situation is very common for VNOVOL errors and does not
    represent an actual problem. For the fileserver, nonexistent volumes
    should be caught before we hit attach2 (in e.g. GetVolume when we
    can't find a volume structure), so errors here can be significant and
    should be rare. But for e.g. the volserver, when we try to use a given
    volume id, we just try to attach it directly, so if the volume doesn't
    exist, we will hit this code path.
    
    This can happen pretty often for the volserver, since many volume
    operations try to determine if a volume already exists by trying to
    attach it. In those cases, this error message is pretty much useless
    noise. So, get rid of it if we are non-fileserver, and the error we
    got is VNOVOL. It is not as important for non-fileserver that we put a
    volume in an error state, since volume states are much more transient
    for non-fileserver programs, since the volume structs don't stay
    around very long.
    
    Change-Id: Ie2c221af2b55af70d725f0f52dacbb7fd8788349
    Reviewed-on: http://gerrit.openafs.org/9907
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>

 src/vol/volume.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

-- 
OpenAFS Master Repository