OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_76-3961-g2bbba42

Gerrit Code Review gerrit@openafs.org
Tue, 8 Oct 2013 05:49:28 -0700 (PDT)


The following commit has been merged in the master branch:
commit 2bbba424ad6728a221688f782b4df90bf6da4a63
Author: Ben Kaduk <kaduk@mit.edu>
Date:   Wed May 29 19:18:22 2013 -0400

    FBSD: plug refcount leak in pioctl
    
    When gop_lookupname_user returns a non-NULL vnode, the vnode came
    from afs_GetVCache (by way of afs_lookup) which takes a reference
    on the vnode entry.  There's no need to take another spurious
    reference here.  The existing code already knows that there's a
    reference in place, as there is an AFS_RELE down where FBSD80_ENV
    unlocks the vnode if it's locked (that code is also suspicious).
    
    Prior to this patch, things like 'fs flush /path/to/file' would
    leak a reference on that cache entry, preventing clean shutdown.
    
    Change-Id: Iefb7be16bb76b709ffd7cfc082ef9078adf9e354
    Reviewed-on: http://gerrit.openafs.org/9957
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>

 src/afs/afs_pioctl.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

-- 
OpenAFS Master Repository