OpenAFS Master Repository branch, openafs-stable-1_6_x, updated. openafs-stable-1_6_5-121-gce19d1d
Gerrit Code Review
gerrit@openafs.org
Thu, 31 Oct 2013 10:26:28 -0700 (PDT)
The following commit has been merged in the openafs-stable-1_6_x branch:
commit ce19d1de2a12a31db8785309e108253c2a401076
Author: Ben Kaduk <kaduk@mit.edu>
Date: Wed May 29 19:18:22 2013 -0400
FBSD: plug refcount leak in pioctl
When gop_lookupname_user returns a non-NULL vnode, the vnode came
from afs_GetVCache (by way of afs_lookup) which takes a reference
on the vnode entry. There's no need to take another spurious
reference here. The existing code already knows that there's a
reference in place, as there is an AFS_RELE down where FBSD80_ENV
unlocks the vnode if it's locked (that code is also suspicious).
Prior to this patch, things like 'fs flush /path/to/file' would
leak a reference on that cache entry, preventing clean shutdown.
Reviewed-on: http://gerrit.openafs.org/9957
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
(cherry picked from commit 2bbba424ad6728a221688f782b4df90bf6da4a63)
Change-Id: If9435903b32ca7001b418bc7a0fb611bda4d424e
Reviewed-on: http://gerrit.openafs.org/10380
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
src/afs/afs_pioctl.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
--
OpenAFS Master Repository