OpenAFS Master Repository branch, openafs-stable-1_6_x, updated. openafs-stable-1_6_5-54-gfea397b

Gerrit Code Review
Mon, 9 Sep 2013 01:39:47 -0700 (PDT)

The following commit has been merged in the openafs-stable-1_6_x branch:
commit fea397b0433ae3cc1155a3f826b0776eee23a497
Author: Andrew Deason <>
Date:   Wed Nov 28 17:22:21 2012 -0600

    vol: Let non-usable volumes attach for non-DAFS
    Before DAFS, volumes that were not inService/blessed were not
    accessible by normal clients, but were still allowed to attach. That
    is, access to clients was prevented at VGetVolume-time, rather than at
    attach-time. Commit 939382c5 tried to short-circuit this by detecting
    this volume state at attach-time. However, volume utilities (e.g.
    volserver) can give us back a volume over FSSYNC when they are done
    with the volume, and for non-DAFS, we then try to attach the volume.
    So, with 939382c5 that attachment will fail when volserver gives us
    back a volume that is not inService/blessed (which can happen for some
    normal volume operations).
    This situation is not terrible, since either way the volume is not
    usable by clients (since the volume didn't attach), and the volume is
    still usable by volserver (since volserver is allowed to check out
    nonexistent volumes). But it is a deviation from pre-DAFS behavior and
    it can result in confusing error messages, so revert the 939382c5
    behavior for non-DAFS.
    For DAFS, this behavior is fine, since the fileserver does not attach
    a volume unless it is trying to service a client request. So, leave it
    for DAFS.
    FIXES 131505
    Tested-by: BuildBot <>
    Reviewed-by: Derrick Brashear <>
    (cherry picked from commit 988f66c5c3bd4c4f23bfa53e69a52ed52c4e3ab9)
    Change-Id: I08b55b30047fc19788e2c83ada1ecd80456f1f74
    Tested-by: BuildBot <>
    Reviewed-by: Mark Vitale <>
    Reviewed-by: Andrew Deason <>
    Reviewed-by: Stephan Wiesand <>

 src/vol/volume.c |   15 +++++++++------
 1 files changed, 9 insertions(+), 6 deletions(-)

OpenAFS Master Repository