OpenAFS Master Repository branch, openafs-stable-1_6_x, updated. openafs-stable-1_6_5-84-g2d1ed3a
Gerrit Code Review
gerrit@openafs.org
Tue, 24 Sep 2013 05:35:15 -0700 (PDT)
The following commit has been merged in the openafs-stable-1_6_x branch:
commit 2d1ed3a1108de01ac6a967daf3fc71646703b9f2
Author: Andrew Deason <adeason@sinenomine.net>
Date: Thu May 30 17:40:58 2013 -0500
ihandle: Fix fdInUseCount leak on EMFILE
Here, we close closeFd, but currently we don't decrement fdInUseCount.
Since we retry the open immediately afterwards, this means we can leak
fdInUseCount references. For example, if we retry this 5 times and get
EMFILE on each attempt, we will close 5 FDs, but not decrement
fdInUseCount at all.
To fix this, decrement fdInUseCounter when we close a file for EMFILE.
Reviewed-on: http://gerrit.openafs.org/9967
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
(cherry picked from commit 48344381d7a87a3617ec14ffc9f2d9735805ada6)
Change-Id: I03aee981c0b9663ac937c6165796f19366acec1e
Reviewed-on: http://gerrit.openafs.org/10175
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
src/vol/ihandle.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
--
OpenAFS Master Repository