OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_76-4500-g47a1a78

Gerrit Code Review
Wed, 3 Dec 2014 01:10:55 -0500

The following commit has been merged in the master branch:
commit 47a1a786786bc7f1e3939aff9100c2196cfcb5a7
Author: Mark Vitale <>
Date:   Tue May 13 19:18:57 2014 -0400

    kauth: fix klog principal name parsing
    If a principal name is specified to the klog command, it is not
    correctly passed in the pw structure.  This in turn causes
    uninitialized storage to be passed to ka_UserAuthenticateGeneral.
    This may either lead to a segmentation fault in klog, or cause
    garbage to be passed to the kaserver, leading to garbage in some
    log and audit messages.  In all cases it is impossible to authenticate
    to kaserver with a specified principal name.  However, klog
    still works correctly when no principal name is specified.
    This was introduced by commit 68ce3aa814a7e3085242e705f013f05ed5da2d5c
    which removed lclpw to eliminate a clang warning.  However, the clang
    warning was misleading in this case, as lclpw was actually used
    (confusingly) to indirectly update the pw structure.
    Instead of reverting this commit, just update pw->pwname directly.
    Change-Id: I565360c6e2f970637422e8b01998d3fc29874ec4
    Reviewed-by: Mark Vitale <>
    Reviewed-by: Perry Ruiter <>
    Reviewed-by: Chas Williams - CONTRACTOR <>
    Reviewed-by: Benjamin Kaduk <>
    Tested-by: BuildBot <>
    Reviewed-by: Jeffrey Altman <>

 src/kauth/klog.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

OpenAFS Master Repository