OpenAFS Master Repository branch, openafs-stable-1_6_x, updated. openafs-stable-1_6_6-23-gdda87b1

Gerrit Code Review
Wed, 12 Feb 2014 08:46:21 -0800 (PST)

The following commit has been merged in the openafs-stable-1_6_x branch:
commit dda87b13a5464aa345b8d405da4afc6ce0c4cd6a
Author: Marc Dionne <>
Date:   Thu Jan 30 13:50:37 2014 -0500

    Linux: When revalidating, don't drop in-use dentries
    The Linux client can get into a state where the current working
    directory is seen as "deleted" by some tools, while it is still
    there and accessible to "ls" and other tools.  This has been
    reported by several users and sites.
    One scenario that has been observed while debugging:
    - A process does a chdir() into a directory
    - This stores a pointer to the dir's dentry in the task structure
    - The server hosting the volume goes offline temporarily
    - The dentry for the directory is passed to afs_linux_dentry_revalidate
    - afs_linux_dentry_revalidate calls afs_lookup which returns an
    error (110 - ETIMEDOUT)
    - It then considers the dentry not valid, and calls d_drop()
    - d_drop unhashes the dentry unconditionally
    - Server comes back up, but dentry is still unhashed
    - getcwd() fetches the task structure pointer to the current dir
    dentry.  If unhashed, it returns ENOENT, and the vfs layer is
    not involved at all.
    At that point, many things won't work and there is no obvious way
    for the user to get the directory rehashed.
    Instead of calling d_drop directly, call d_invalidate instead, as
    it will only drop (unhash) the dentry if we're the only one holding
    a reference.  Since d_invalidate will also call shrink_dcache_parent,
    also remove that call from our code so it doesn't get called twice.
    Tested-by: BuildBot <>
    Tested-by: Anders Kaseorg <>
    Reviewed-by: Derrick Brashear <>
    (cherry picked from commit 997f7fce437787a45ae0584beaae43affbd37cce)
    Change-Id: I1e2b46fd076e96a7acbf3443f118fac8355d3e8c
    Tested-by: Anders Kaseorg <>
    Tested-by: BuildBot <>
    Reviewed-by: Andrew Deason <>
    Reviewed-by: Marc Dionne <>
    Reviewed-by: D Brashear <>
    Reviewed-by: Stephan Wiesand <>

 src/afs/LINUX/osi_vnodeops.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

OpenAFS Master Repository