OpenAFS Master Repository branch, openafs-stable-1_6_x, updated. openafs-stable-1_6_6-29-g618343f

Gerrit Code Review
Tue, 25 Feb 2014 09:10:40 -0800 (PST)

The following commit has been merged in the openafs-stable-1_6_x branch:
commit 618343f0261bb5ffa036d93f1a3bc313ed76a037
Author: Andrew Deason <>
Date:   Tue Dec 10 17:02:34 2013 -0600

    cellconfig: Do not use 'long' for dbserver IPs
    A few places in this file assume that our dbserver IP addresses are
    "long"s. A long int can be 8 bytes on some platforms, but we know
    these IP addresses are all 4-byte integers. In the rare instances
    where we have the maximum number of dbservers, this can overwrite a
    bit of extra memory. This can also result in a misaligned access on
    platforms such as SPARC v9, since the elements of he->h_addr_list are
    not guaranteed to be 8-byte aligned.
    So instead, treat these as 4-byte integers. For copying out of
    he->h_addr_list, also use a memcpy anyway to be safe, since we are not
    guaranteed alignment.
    Tested-by: BuildBot <>
    Reviewed-by: Jeffrey Altman <>
    (cherry picked from commit d8f75d3206eaa56b3a819a5bc13a4bf3a9130512)
    Change-Id: I2568577b05f47ebc75b34a9cd106fceac8a31ef7
    Tested-by: BuildBot <>
    Reviewed-by: Andrew Deason <>
    Reviewed-by: Benjamin Kaduk <>
    Reviewed-by: Stephan Wiesand <>

 src/auth/cellconfig.c |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

OpenAFS Master Repository