OpenAFS Master Repository branch, openafs-stable-1_6_x, updated. openafs-stable-1_6_6-37-g65847d1

Gerrit Code Review
Thu, 27 Feb 2014 08:01:39 -0800 (PST)

The following commit has been merged in the openafs-stable-1_6_x branch:
commit 65847d19c6a795709cb5523e5927e5d0a9b24302
Author: Andrew Deason <>
Date:   Tue Oct 1 17:31:44 2013 -0500

    namei: Set inconsistent linktable linkCount to 0
    Currently, if we detect an inconsistent linktable filename (where the
    filename indicates it's for a different volume than the directory path
    indicates), we don't set the linkCount for the inode info. This means
    that our caller will get random garbage for the linkCount.
    In many cases this value is ignored, but for the salvager, if this is
    the only linktable file we find, we treat it as the linktable we
    should be using. Thus, if linkCount contains undefined data, we might
    try to INC or DEC the linktable a bunch of times, depending on what
    random stack garbage the linkCount is filled with.
    The salvager shouldn't be INC/DEC'ing these linktables according to
    the their linkCount anyway, but in the meantime, at least ensure that
    this doesn't contain stack garbage, so we ensure that we won't try to
    INC or DEC this thousands or millions of times.
    Tested-by: BuildBot <>
    Reviewed-by: Derrick Brashear <>
    (cherry picked from commit 2286fac1447e2e9e834957ec414cb5605f51e63b)
    Change-Id: I480ad328d594531869874b4207629533553bfc64
    Reviewed-by: Andrew Deason <>
    Reviewed-by: D Brashear <>
    Tested-by: BuildBot <>
    Reviewed-by: Stephan Wiesand <>

 src/vol/namei_ops.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

OpenAFS Master Repository