OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_76-4104-gbaf6af8
Gerrit Code Review
Fri, 17 Jan 2014 10:38:35 -0800 (PST)
The following commit has been merged in the master branch:
Author: Benjamin Kaduk <firstname.lastname@example.org>
Date: Thu Jan 9 22:42:26 2014 -0500
afs_fetchstore: avoid use of uninitialized variable
rxfs_fetchInit() attempts to do a 64-bit RPC first, but falls back
to the 32-bit StartRXAFS_FetchData() if the server appears to not
support the 64-bit RPCs.
We correctly did not read a length from the call if the FetchData
RPC(s) failed, but proceeded to assign from the 'length' local
variable into the 'alength' output variable unconditionally later on.
Instead of blindly continuing on, jump to the error-handling part of
the routine when we cannot read a length from the call. This has the
side effect of skipping an afs_Trace3() point in the error case.
Reviewed-by: Derrick Brashear <email@example.com>
Tested-by: Benjamin Kaduk <firstname.lastname@example.org>
src/afs/afs_fetchstore.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
OpenAFS Master Repository