OpenAFS Master Repository branch, openafs-stable-1_6_x, updated. openafs-stable-1_6_8-25-g2e644c3
Gerrit Code Review
gerrit@openafs.org
Tue, 3 Jun 2014 12:31:15 -0400
The following commit has been merged in the openafs-stable-1_6_x branch:
commit 2e644c3d860b5576be0cdf69b09b554fc4af1542
Author: Simon Wilkinson <sxw@your-file-system.com>
Date: Fri Mar 1 11:09:04 2013 +0000
bucoord: Remove theoretical overflow of ubik array
The ubik connections array is NULL terminated, so we have to
ensure that there is enough space for the trailing NULL. As the
array is MAXSERVERS elements long, this means that we can only
store MAXSERVERS-1 connections in it.
This problem will never be encountered by the correct code, as
the number of hosts returned from afsconf_Open is capped at
MAXHOSTSPERCELL (currently 8). MAXSERVERS is currently 20. However,
fix the bug in case we increase MAXHOSTSPERCELL at some point in
the future.
Caught by coverity (#985576)
Reviewed-on: http://gerrit.openafs.org/9322
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
(cherry picked from commit c0fba6eab519bd1bb6929b788361219f97da7212)
Change-Id: I1e2556df6867ebb7b6b311e54a0271fb6fe631fd
Reviewed-on: http://gerrit.openafs.org/11032
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
src/bucoord/ubik_db_if.c | 10 +++++++---
1 files changed, 7 insertions(+), 3 deletions(-)
--
OpenAFS Master Repository