OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_76-4288-g1673764

Gerrit Code Review
Thu, 5 Jun 2014 07:18:03 -0400

The following commit has been merged in the master branch:
commit 1673764ea091a3f02a64a3d853c3e14f758cdda7
Author: Andrew Deason <>
Date:   Wed Jun 4 09:42:46 2014 -0500

    bozo: Ignore ListKeys ka_KeyCheckSum return value
    With commit c04de52da4e89e15b211b4a19a3d9bc4d612b209, an error in
    ka_KeyCheckSum here makes the entire BOZO_ListKeys RPC to fail. This
    caused two changes:
     - That commit makes the RPC fail in situations where it did not
       before. But even if we cannot calculate the checksum, we can still
       return other information about the key, so this is undesirable.
     - It masks the previous 'code' value, returned from stat(). The
       return code of stat() is now effectively ignored, except for the
       purposes of setting st_mtime, whereas previously a failure caused
       the RPC to fail. This is a behavior change.
    So, effectively revert c04de52da4e89e15b211b4a19a3d9bc4d612b209.
    Explicitly cast the return value of ka_KeyCheckSum to void, to make it
    clear that we are intentionally ignoring the return value, so
    hopefully this will not be flagged as a warning by code analysis tools
    such as coverity.
    Change-Id: Iac745d7c88ed7c2d97660e6949caa63580eef6e2
    Reviewed-by: Benjamin Kaduk <>
    Tested-by: BuildBot <>
    Reviewed-by: Perry Ruiter <>
    Reviewed-by: D Brashear <>

 src/bozo/bosoprocs.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

OpenAFS Master Repository