OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_76-4297-gd704f1d

Gerrit Code Review gerrit@openafs.org
Tue, 17 Jun 2014 11:48:37 -0400


The following commit has been merged in the master branch:
commit d704f1d4dc3fca4d903c443130374da2284f3f15
Author: Benjamin Kaduk <kaduk@mit.edu>
Date:   Mon Jun 16 12:44:08 2014 -0400

    Use an unsigned type for bitmask values
    
    As noted by clang -Wshift-sign-overflow, the expression "1<<31"
    overflows the signed int type, giving undefined behavior.
    
    Use an unsigned type to make the result of the shift defined
    behavior by the C99 standard.
    
    Also change an instance of "1<<31" that was checking for whether the
    most significant bit was set, as it's still undefined behavior.
    
    Change-Id: I8cf9443aa92470181044fc3b63d491da18ff5e34
    Reviewed-on: http://gerrit.openafs.org/11301
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>

 src/dir/dir.c         |    2 +-
 src/ptserver/ptint.xg |    4 ++--
 src/rx/xdr_rec.c      |    2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

-- 
OpenAFS Master Repository