OpenAFS Master Repository branch, openafs-stable-1_6_x, updated. openafs-stable-1_6_6-48-gd2d749e

Gerrit Code Review
Wed, 12 Mar 2014 06:08:57 -0700 (PDT)

The following commit has been merged in the openafs-stable-1_6_x branch:
commit d2d749ec0c656d6e4c595a5f8c93b164a6cf911b
Author: Simon Wilkinson <>
Date:   Fri Mar 8 16:15:51 2013 +0000

    bos: Remove theoretical overflow in DateOf
    DateOf copies the results of ctime into a static buffer. Typically
    ctime will return a 26 byte string, but if you pass it a year larger
    than 9999 (which we shouldn't), you can get a 32 (or more) byte string.
    Get rid of this unlikely event by using strlcpy for the copy. We already
    truncate at 24 bytes when we remove the \n, so this shouldn't cause any
    further problems.
    Really, this whole thing should be rewritten to use strftime.
    Caught by coverity (#985776)
    Reviewed-by: Derrick Brashear <>
    Reviewed-by: Jeffrey Altman <>
    Tested-by: BuildBot <>
    (cherry picked from commit 8b76110e23160e33716234f9560d22ca5275cb0a)
    Change-Id: I47bdadf0159c12d747040765d28e6e8908678fd1
    Tested-by: BuildBot <>
    Reviewed-by: Jeffrey Altman <>
    Reviewed-by: Michael Meffie <>
    Reviewed-by: Andrew Deason <>
    Reviewed-by: Stephan Wiesand <>

 src/bozo/bos.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

OpenAFS Master Repository