OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_76-4384-gcd030f3

Gerrit Code Review gerrit@openafs.org
Wed, 8 Oct 2014 10:48:14 -0400


The following commit has been merged in the master branch:
commit cd030f3c36c6a6ed6fa721cdcaa98fe4a4fce8a4
Author: Benjamin Kaduk <kaduk@mit.edu>
Date:   Fri Sep 12 17:21:42 2014 -0400

    Normalize LT_deps/LT_objs split
    
    As described in the commit message of
    69f26ece3c4545ecc9099641f7a507796fe9dc77, LT_objs should contain
    the .lo files for the given module, and LT_deps should contain the
    libtool dependencies, i.e., the .la files from other parts of the
    tree.  However, this simple split by file suffix is not correct
    when we are using convenience libraries.  Really, LT_objs represents
    the "new" objects being provided by the module, and LT_deps is
    libraries from other modules that provide functionality on which
    we depend.  Since convenience libraries are just thin aggregates
    of object files, they behave more like object files than libraries
    upon which we depend.  In particular, libafsrpc and libafsauthent
    are wrapper libraries that gather together the functionality of
    several modules and export them as a single library interface;
    they do not have any objects of their own.
    
    However, libafsauthent has a dependency on libafsrpc, which does
    belong in LT_deps (or possibly in LT_libs).
    
    Simon's description of LT_libs leaves a little ambiguity, as it
    does not describe what should be done with non-libtool libraries
    from within OpenAFS.  (At present, these include libafshcrypto
    and librokenafs, both of which are regularly put in LT_libs.)
    I prefer to recast LT_libs as containing externally visible libraries,
    not just external libraries, which rationalizes the inclusion of
    roken and hcrypto there, since we currently install those libraries,
    and build libraries that have shared library dependencies on them.
    
    In the future, as we begin committing to stable shared library
    interfaces for libraries produced by libtool, I would like to
    have those .la files be moved to LT_libs, since they would then
    be external library dependencies of the given module.
    
    Change-Id: Ie50010da84df99cec048c3e39ffeb9d5897fc08c
    Reviewed-on: http://gerrit.openafs.org/11460
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    Tested-by: D Brashear <shadow@your-file-system.com>

 src/libafsauthent/Makefile.in |    6 +++---
 src/libafsrpc/Makefile.in     |    6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

-- 
OpenAFS Master Repository