OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_76-4388-g5d2bd04

[Gerrit Code Review]

The following commit has been merged in the master branch:
commit 6825d6aeaa7c3951aafc216fa3707ae6c62e8691
Author: Benjamin Kaduk <kaduk@mit.edu>
Date:   Fri Sep 12 18:07:51 2014 -0400

    Build a usable pam_afs.so
    
    Our use of libtool for building the pam modules resulted in shared
    objects which had dependencies on liboafs_auth.so and liboafs_kauth.so,
    neither of which are installed.
    
    We still need some way to resolve those dependencies at link time, and
    a dependency on libafsauthent.so seems ill-advised to insert into the
    pam stack, so we are left with only the option of directly linking in
    the requisite functionality.  Fortunately, almost all of the requisite
    convenience libraries of PIC objects already exist to meet the
    requirements of libafsrpc and libafsauthent; the only exception is
    from the auth module.  Here, we require a new convenience library,
    because the pam_afs.krb.so module includes its own version of ktc.o,
    compiled with AFS_KERBEROS_ENV defined, yet the pam_afs.so module
    requiers a ktc.o compiled without AFS_KERBEROS_ENV defined.  The
    convenience library from the auth module can only include one version,
    and would therefore be wrong for the other.  As such, create the new
    libpam_auth.la archive from the BASE_objs in src/auth, and manually
    compile ktc.lo and ktc_krb.lo as needed for the pam modules.
    
    As for libafsrpc and libafsauthent, the convenience libraries included
    from other parts of the tree belong in LT_objs, not LT_deps, because
    they are contributing actual content to be included in the resulting
    library; they are not library dependencies of the output of this module.
    
    Change-Id: I5292718a5494710d166043fd08ad07269ff9fdf2
    Reviewed-on: http://gerrit.openafs.org/11463
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    Tested-by: D Brashear <shadow@your-file-system.com>

 src/auth/Makefile.in |    5 ++++-
 src/pam/Makefile.in  |   35 ++++++++++++++++++++++++++---------
 2 files changed, 30 insertions(+), 10 deletions(-)

-- 
OpenAFS Master Repository