OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_76-4567-g40d97fa

Gerrit Code Review gerrit@openafs.org
Thu, 29 Jan 2015 14:34:35 -0500


The following commit has been merged in the master branch:
commit 40d97fa9f0356fce7aec76d69dbacb81eac3db37
Author: Antoine Verheijen <apv@ualberta.ca>
Date:   Tue Jan 27 19:49:04 2015 -0700

    OpenBSD: Clean up use of LK_CANRECURSE in call to lockmgr()
    
    The LK_CANRECURSE and LK_RECURSEFAIL flags in the call to lockmgr()
    are mutually exclusive. Previous version of OpenBSD didn't really
    check well for this but more recent versions look for the conflict
    and take a kernel panic when they're both set.
    
    The OpenBSD kernel module currently just blindly sets the
    LK_CANRECURSE flag in its call to lockmgr(). This patch changes
    that behaviour so that it checks to make sure that the LK_RECURSEFAIL
    flags is not set before it actually applies the LK_CANRECURSE flag.
    That removes the kernel panics that have started to arise.
    
    This behaviour is more consistent with other OpenBSD code that makes
    use of the LK_CANRECURSE flag.
    
    Change-Id: Ie435559f4b88195136e09c6184543861f06257da
    Reviewed-on: http://gerrit.openafs.org/11699
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>

 src/afs/OBSD/osi_vnodeops.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

-- 
OpenAFS Master Repository