OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_76-4622-gb8648db

Gerrit Code Review
Tue, 26 May 2015 13:58:55 -0400

The following commit has been merged in the master branch:
commit b8648dbefb3968329d20cad8976ce15947428678
Author: Benjamin Kaduk <>
Date:   Wed May 20 10:57:53 2015 -0400

    afsio: switch BreakUpPath to strdup
    The current version of BreakUpPath is slightly broken, since
    commit 4e68282e26b0c4569d25d076d54274f0da47a691 -- it has two
    output parameters but takes only one length parameter for the
    size of the output buffers passed in.  The callers ended up using
    the shorter of the buffer lengths in question, so there is not
    a risk of a buffer overrun, but long paths would not be properly
    There is not really any need to pass in a length at all, since
    what is going on is conceptually strdup, and there is no real
    need to use strlcpy at all.  Make the change from strlcpy to
    str(n)dup, and adjust callers to free the outputs as appropriate.
    While here, convert writeFile() to use goto and a cleanup handler
    to avoid leaks.
    Change-Id: Ib742cb73a6d70aa863c8d30423416887b977677b
    Tested-by: BuildBot <>
    Reviewed-by: Jeffrey Altman <>
    Reviewed-by: Daria Brashear <>

 src/venus/afsio.c |  104 ++++++++++++++++++++++++++++-------------------------
 1 files changed, 55 insertions(+), 49 deletions(-)

OpenAFS Master Repository