OpenAFS Master Repository branch, openafs-stable-1_6_x, updated. openafs-stable-1_6_12pre1-5-g7dff003

Gerrit Code Review
Thu, 28 May 2015 08:51:20 -0400

The following commit has been merged in the openafs-stable-1_6_x branch:
commit 7dff0032992eac3c078f03e520aee5fed00f2b21
Author: Ben Kaduk <>
Date:   Wed Feb 11 17:47:10 2015 -0500

    Remove spurious NULL checks
    clang 3.5 is more aggressive about these checks than the previous
    FreeBSD system compiler, so new warnings (which became errors)
    appeared on FreeBSD 11-CURRENT.
    In afs_dcache.c, checking &tdc->f for NULL-ness has no effect.
    The struct fcache f member of struct dcache is an ordinary structure
    element; its address will be the value of tdc plus the offset of
    f within struct dcache, which will not be NULL even if tdc is NULL.
    In ubik_db_if.c, udbHandle is a file-scope global and thus has
    allocated storage; the address of a member variable will never
    be NULL.  The 0 it was compared against was spelled RX_SECIDX_NULL,
    which shows the intended check, which is for the value of the
    uh_scIndex member variable, not its address.
    In afscp_server.c, srv->conns can never be NULL since conns is a member
    variable of struct afscp_server (of array type, containing pointers
    to struct rx_connection).  Comparing the array member variable against
    NULL is comparing the address of the array, which is never NULL since
    it is not allocated separately from struct afscp_server.
    In fssync-debug.c, state.vop->partName is never NULL because
    common_volop_prolog always allocates for state.vop, and the
    partName member variable of struct fssync_state is of array type,
    and thus is not separately allocated from the containing structure.
    Reviewed-by: Chas Williams - CONTRACTOR <>
    Reviewed-by: Perry Ruiter <>
    Reviewed-by: Benjamin Kaduk <>
    Tested-by: BuildBot <>
    (cherry picked from commit fb499c2406450fa5dc423a0b038266d3b8e79e33)
    Change-Id: I13799a3362508672136f8c603eabdfc0f3ee072d
    Tested-by: BuildBot <>
    Reviewed-by: Benjamin Kaduk <>
    Reviewed-by: Stephan Wiesand <>

 src/afs/afs_dcache.c        |   14 ++++++--------
 src/bucoord/ubik_db_if.c    |    2 +-
 src/libafscp/afscp_server.c |    2 +-
 src/vol/fssync-debug.c      |    2 +-
 4 files changed, 9 insertions(+), 11 deletions(-)

OpenAFS Master Repository