OpenAFS Master Repository branch, openafs-stable-1_6_x, updated. openafs-stable-1_6_15-18-g9ef3a6a

Gerrit Code Review gerrit@openafs.org
Fri, 6 Nov 2015 07:28:07 -0500


The following commit has been merged in the openafs-stable-1_6_x branch:
commit 9ef3a6ae65bb80d320525ad561e10f960269d182
Author: Jeffrey Hutzelman <jhutz@cmu.edu>
Date:   Tue Jun 18 12:35:36 2013 -0400

    userok.c: Fix fixed-size on-stack path buffers
    
    Several functions in src/auth/userok.c construct pathnames in fixed
    size buffers on their stacks.  Those buffers are simultaneously too
    small for the purpose for which they are used and too large to be
    placed on the stack.  This change replaces these fixed-size buffers
    with dynamically-allocated buffers which are either exactly the right
    size (due to asprintf) or have size AFSDIR_PATH_MAX.
    
    FIXES 130719
    
    Reviewed-on: http://gerrit.openafs.org/9986
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    (cherry picked from commit 68e02987f62e1c507ddf7fd35847338b130c243d)
    
    This file has diverged quite substantially between master and 1.6.x,
    so though it is marked as a "cherry-pick", this patch was substantially
    rewritten for the 1.6 branch.  In particular, we must use afs_asprintf()
    since asprintf() is not available everywhere.
    
    Change-Id: Iac62cb8293e7b28b422e7401eccb1f26841aff66
    Reviewed-on: http://gerrit.openafs.org/11436
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams <3chas3@gmail.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Daria Phoebe Brashear <shadow@your-file-system.com>
    Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

 src/auth/userok.c |  104 ++++++++++++++++++++++++++++++++++++++---------------
 1 files changed, 75 insertions(+), 29 deletions(-)

-- 
OpenAFS Master Repository