OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_76-4843-g8d244c4

Gerrit Code Review
Wed, 4 May 2016 19:36:34 -0400

The following commit has been merged in the master branch:
commit 8d244c4a52b2111030e74fd32f79136aca5b8904
Author: Andrew Deason <>
Date:   Tue Apr 1 13:28:20 2014 -0500

    vos: Remove redundant " done" messages
    In 1.4, a 'vos backup' command looked like this:
        $ vos backup root.cell -verbose
        Re-cloning backup volume 537351386 ... done
        Created backup volume for root.cell
    As of 1.6.1, this output now looks like this:
        $ vos backup root.cell -verbose
        Re-cloning backup volume 537351386 ... done
        Created backup volume for root.cell
    Note the extra " done". This change can break scripts that parse "vos"
    output, but mainly it just looks confusing and doesn't make any sense.
    This extra " done" appeared in verbose output for 'vos backup', 'vos
    backupsys', and 'vos clone'. It was introduced by commit 13a4f2b1,
    which added a VDONE to DoVolClone. This new VDONE call does make
    sense, as this does make DoVolClone more self-contained, but the old
    VDONE messages were not removed, so an extra " done" got printed.
    In addition, commit 13a4f2b1 introduced a new call to DoVolDelete
    followed by a VDONE, even though DoVolDelete calls VDONE itself,
    causing another redundant " done".
    To get rid of all of these redundant " done" messages, remove some
    extra VDONE calls in UV_BackupVolume and UV_CloneVolume.
    Almost all other calls to VDONE in vsprocs.c are matched by a
    preceding message that says what we are doing. The sole exception is
    UV_ChangeLocation, which outputs a " done" without any preceding
    message. However, this is the behavior that UV_ChangeLocation (and
    thus 'vos changeloc') has always has since it was introduced in
    Thanks to Jakub Moscicki of CERN, who originally reported this issue
    at EAKC 2014.
    Change-Id: I6a13c85e73deb59b511086207a296f4017f799dc
    Reviewed-by: Michael Meffie <>
    Tested-by: BuildBot <>
    Reviewed-by: Benjamin Kaduk <>

 src/volser/vsprocs.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

OpenAFS Master Repository