OpenAFS Master Repository branch, openafs-stable-1_6_x, updated. openafs-stable-1_6_19-7-g2161e74

Gerrit Code Review
Wed, 30 Nov 2016 15:07:01 -0500

The following commit has been merged in the openafs-stable-1_6_x branch:
commit 2161e741da94b3ceb60cbd57a78643dd4169dfb7
Author: Mark Vitale <>
Date:   Mon Nov 7 14:16:50 2016 -0500

    dir: do not leak contents of deleted directory entries
    Deleting an AFS directory entry (afs_dir_Delete) merely removes the
    entry logically by updating the allocation map and hash table.  However,
    the entry itself remains on disk - that is, both the cache manager's
    cache partition and the fileserver's vice partitions.
    This constitutes a leak of directory entry information, including the
    object's name and MKfid (vnode and uniqueid).  This leaked information
    is also visible on the wire during FetchData requests and volume
    Modify afs_dir_Delete to clear the contents of deleted directory
    Patchset notes:
    This commit only prevents leaks for newly deleted entries.  Another
    commit in this patchset prevents leaks of partial object names upon
    reuse of pre-existing deleted entries.  A third commit in this
    patchset prevents yet another kind of directory entry leak, when
    internal buffers are reused to create or enlarge existing directories.
    All three patches are required to prevent new leaks.  Two additional
    salvager patches are also included to assist administrators in the
    cleanup of pre-existing leaks.
    [ style nit for sizeof() argument]
    Reviewed-by: Mark Vitale <>
    Tested-by: Mark Vitale <>
    Reviewed-by: Michael Meffie <>
    Reviewed-by: Benjamin Kaduk <>
    (cherry picked from commit f591f6fae3d8b8d44140ca64e53bad840aeeeba0)
    Change-Id: I41f76649f4bed609793b944db32c5ae62aa07458
    Reviewed-by: Michael Meffie <>
    Reviewed-by: Mark Vitale <>
    Tested-by: BuildBot <>
    Reviewed-by: Stephan Wiesand <>

 src/dir/dir.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

OpenAFS Master Repository