OpenAFS Master Repository branch, master, updated. openafs-stable-1_8_0pre1-23-gdd97cb7
Gerrit Code Review
gerrit@openafs.org
Fri, 10 Feb 2017 19:08:53 -0500
The following commit has been merged in the master branch:
commit dd97cb7a7447313dbc1da65104786fe03ede7c8d
Author: Andrew Deason <adeason@sinenomine.net>
Date: Fri Feb 10 01:29:28 2017 -0600
PERLUAFS: Modernize lang-specific swig typemaps
Currently, our swig bindings for PERLUAFS define a couple of typemaps
like so:
%typemap(in, numinputs=1, perl5) (char *READBUF, int LENGTH) {
[...]
}
Embedding the target language name in the typemap arguments is a very
old way of specifying what language the typemap is for; they were
removed after swig 1.1. With swig 3.0.x releases (and possibly
others), the specific combination of this deprecated syntax and some
other features we're using causes a segfault. That's clearly a bug in
swig, but we shouldn't be using the deprecated syntax anyway.
Update this to instead use preprocessor symbols to specify
language-specific typemaps (#ifdef SWIGPERL). We only actually define
these for perl right now, so make sure to throw an error if we're not
running for perl.
FIXES 134103
Change-Id: I14264a2dfada53d99413808ed5d60b79b1ee44f3
Reviewed-on: https://gerrit.openafs.org/12517
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
src/libuafs/ukernel_swig.i | 12 ++++++++----
1 files changed, 8 insertions(+), 4 deletions(-)
--
OpenAFS Master Repository