OpenAFS Master Repository branch, master, updated. BP-openafs-stable-1_8_x-190-ge7678fb
Gerrit Code Review
gerrit@openafs.org
Tue, 14 Aug 2018 17:57:44 -0400
The following commit has been merged in the master branch:
commit 388eaec3452ed4b18a95ee34efcbe4cf64814701
Author: Michael Meffie <mmeffie@sinenomine.net>
Date: Thu Mar 15 18:53:59 2018 -0400
roken: do not clobber __attribute__
The roken-common.h header defines an empty macro called __attribute__
when HAVE___ATTRIBUTE__ is not defined. This macro conditionally removes
the `format' function attributes in the roken headers at compile time.
Unfortunately, the empty __attribute__ macro will also clobber other
attribute types encountered after the roken.h header inclusion.
This is not an issue when building under gcc or clang, since the empty
attribute macro will not be defined. However Solaris Studio supports a
subset of the function attribute types, with `format' not currently
supported. This means roken will define an empty __attribute__ macro,
which prevents the use of other attribute types.
This commit does not change the roken files directly because they are
external. Instead, the processing of the roken.h.in file has been
updated to undefine the __attribute__ macro at the end of the generated
roken.h header.
Change-Id: Iea5622ae175e7f82a60780838948178bd7f8b56f
Reviewed-on: https://gerrit.openafs.org/12961
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
src/roken/Makefile.in | 7 +++++--
src/roken/roken-post.h | 8 ++++++++
2 files changed, 13 insertions(+), 2 deletions(-)
--
OpenAFS Master Repository