From gerrit@openafs.org Fri Dec 14 14:55:56 2018 From: gerrit@openafs.org (Gerrit Code Review) Date: Fri, 14 Dec 2018 09:55:56 -0500 Subject: OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_2-1-g3143627 Message-ID: <201812141455.wBEEtutM098131@openafs.MIT.EDU> The following commit has been merged in the openafs-stable-1_8_x branch: commit 3143627f9b7f91743a85cd8fd8f00f913a31f17c Author: Mark Vitale Date: Tue Sep 11 16:29:59 2018 -0400 butc: repair build error Commit c43169fd36348783b1a5a55c5bb05317e86eef82 introduced a build error by invoking TLog with an extraneous set of internal parentheses. Remove the offending parentheses. Reviewed-on: https://gerrit.openafs.org/13311 Tested-by: BuildBot Reviewed-by: Benjamin Kaduk (cherry picked from commit 91bab84e7a3b7de2591c475ba4912b0db8899f05) Change-Id: I06df561daf37330e6fdd9c9d41b55daa4d6b3886 Reviewed-on: https://gerrit.openafs.org/13328 Tested-by: BuildBot Reviewed-by: Michael Meffie Reviewed-by: Marcio Brito Barbosa Reviewed-by: Cheyenne Wills Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand src/butc/tcmain.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) -- OpenAFS Master Repository From gerrit@openafs.org Mon Dec 17 10:06:07 2018 From: gerrit@openafs.org (Gerrit Code Review) Date: Mon, 17 Dec 2018 05:06:07 -0500 Subject: OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_2-2-g354fef1 Message-ID: <201812171006.wBHA67Vv117429@openafs.MIT.EDU> The following commit has been merged in the openafs-stable-1_8_x branch: commit 354fef1f0af9272cd5bf1e8a6466a3b727dcc08d Author: Michael Meffie Date: Mon Apr 25 11:06:11 2016 -0400 ubik: convert ubik_print to ViceLog Use the server logging macros instead of the utility functions to avoid function call overhead, especially at logging level 25. The server logging macros perform a logging level check in-line to avoid the unnecessary ubik_dprint* calls. Reviewed-on: https://gerrit.openafs.org/12619 Reviewed-by: Andrew Deason Reviewed-by: Marcio Brito Barbosa Reviewed-by: Michael Meffie Reviewed-by: Mark Vitale Reviewed-by: Benjamin Kaduk Tested-by: BuildBot (cherry picked from commit 343234d221ae8388f55748f5c494a42d5d69bfa0) Change-Id: Icdb60f75a0c6c6efc7793d545f0565c0cd587eae Reviewed-on: https://gerrit.openafs.org/13153 Reviewed-by: Andrew Deason Reviewed-by: Michael Meffie Reviewed-by: Marcio Brito Barbosa Reviewed-by: Mark Vitale Reviewed-by: Cheyenne Wills Tested-by: BuildBot Reviewed-by: Stephan Wiesand src/ubik/beacon.c | 65 +++++++++++++++++++++++------------------------- src/ubik/disk.c | 10 +++--- src/ubik/lock.c | 19 +++++++------ src/ubik/recovery.c | 68 +++++++++++++++++++++++++------------------------- src/ubik/remote.c | 39 ++++++++++++++--------------- src/ubik/ubik.c | 17 ++++++------ src/ubik/ubik.p.h | 11 -------- src/ubik/vote.c | 55 ++++++---------------------------------- 8 files changed, 117 insertions(+), 167 deletions(-) -- OpenAFS Master Repository From gerrit@openafs.org Mon Dec 17 10:07:37 2018 From: gerrit@openafs.org (Gerrit Code Review) Date: Mon, 17 Dec 2018 05:07:37 -0500 Subject: OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_2-3-gb9603bf Message-ID: <201812171007.wBHA7bnH117670@openafs.MIT.EDU> The following commit has been merged in the openafs-stable-1_8_x branch: commit b9603bfb27c3c1d5ae90ed68545a4dd9fe9da862 Author: Mark Vitale Date: Mon May 8 17:50:00 2017 -0400 ubik: disambiguate "Synchonize database with server" msgs Ubik issues the same message in two very different cases: - sync server issues DISK_GetFile to obtain the latest version - non-sync server receives DISK_SendFile from the sync server Modify the messages so they provide more information and are distinguishable from each other. Reviewed-on: https://gerrit.openafs.org/12615 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Benjamin Kaduk (cherry picked from commit b9fe4d4290ad19faf3b5fb5dc0c3b1ee3ee5ab69) Change-Id: I806c2ce5ada097b07022d8c4da81f613a3f9989c Reviewed-on: https://gerrit.openafs.org/13186 Reviewed-by: Mark Vitale Reviewed-by: Michael Meffie Reviewed-by: Joe Gorse Reviewed-by: Andrew Deason Reviewed-by: Marcio Brito Barbosa Reviewed-by: Cheyenne Wills Tested-by: BuildBot Reviewed-by: Stephan Wiesand src/ubik/recovery.c | 2 +- src/ubik/remote.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- OpenAFS Master Repository From gerrit@openafs.org Mon Dec 17 10:08:46 2018 From: gerrit@openafs.org (Gerrit Code Review) Date: Mon, 17 Dec 2018 05:08:46 -0500 Subject: OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_2-4-g10157d8 Message-ID: <201812171008.wBHA8kHY117883@openafs.MIT.EDU> The following commit has been merged in the openafs-stable-1_8_x branch: commit 10157d82c3e8f7cbdec768d92119ed5be126b844 Author: Michael Meffie Date: Thu Jun 14 15:01:18 2018 -0400 ubik: do not assign variables in logging argument lists Several logging statements in ubik contain an assignment statement within the logging function call argument list, which would set a variable as side effect of evaluating the function call arguments. These embedded assignments are problematic since the logging function calls have been replaced by ViceLog macros, which avoid the overhead of a function call depending on logging levels. Remove the embedded assignments within the logging argument lists so the variables are always set regardless of the logging level. Reviewed-on: https://gerrit.openafs.org/13211 Tested-by: BuildBot Reviewed-by: Joe Gorse Reviewed-by: Andrew Deason Reviewed-by: Marcio Brito Barbosa Reviewed-by: Benjamin Kaduk (cherry picked from commit 472d6b1ee2f7de415e0fa0f8be0636f86956b6fc) Change-Id: I230f71022a58445c99adc67ae1b888caa4ce260e Reviewed-on: https://gerrit.openafs.org/13218 Reviewed-by: Andrew Deason Reviewed-by: Mark Vitale Reviewed-by: Michael Meffie Reviewed-by: Marcio Brito Barbosa Reviewed-by: Cheyenne Wills Tested-by: BuildBot Reviewed-by: Stephan Wiesand src/ubik/recovery.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) -- OpenAFS Master Repository From gerrit@openafs.org Mon Dec 17 10:10:04 2018 From: gerrit@openafs.org (Gerrit Code Review) Date: Mon, 17 Dec 2018 05:10:04 -0500 Subject: OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_2-6-gb71f75c Message-ID: <201812171010.wBHAA4d2118119@openafs.MIT.EDU> The following commit has been merged in the openafs-stable-1_8_x branch: commit b71f75cad51cf58260d0593635d66dd367a2af1a Author: Mark Vitale Date: Fri May 4 15:42:14 2018 -0400 ubik: make ContactQuorum_* routines static Most of the ContactQuorum_* routines are only used in ubik.c, so make them all static - except for ContactQuorum_DISK_SetVersion, which is called from disk.c. Reviewed-on: https://gerrit.openafs.org/13078 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Benjamin Kaduk (cherry picked from commit 27d7b8fe4603c39362983758fe6a749fa5ffa4e5) Change-Id: I70721aef02f5f2e203c1877428c46c49ea1cb7c9 Reviewed-on: https://gerrit.openafs.org/13188 Reviewed-by: Michael Meffie Reviewed-by: Andrew Deason Reviewed-by: Joe Gorse Reviewed-by: Mark Vitale Reviewed-by: Marcio Brito Barbosa Reviewed-by: Cheyenne Wills Tested-by: BuildBot Reviewed-by: Stephan Wiesand src/ubik/ubik.c | 8 ++++---- src/ubik/ubik.p.h | 20 -------------------- 2 files changed, 4 insertions(+), 24 deletions(-) -- OpenAFS Master Repository From gerrit@openafs.org Mon Dec 17 10:12:30 2018 From: gerrit@openafs.org (Gerrit Code Review) Date: Mon, 17 Dec 2018 05:12:30 -0500 Subject: OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_2-7-g3927292 Message-ID: <201812171012.wBHACU0L118555@openafs.MIT.EDU> The following commit has been merged in the openafs-stable-1_8_x branch: commit 39272929fc528a4c6af05e74b98518a3bae18462 Author: Andrew Deason Date: Thu May 10 16:22:52 2018 -0500 ubik: Buffer log writes with stdio Currently, when we write ubik i/o operations to the db log, we tend to issue several syscalls involving small writes and fstat()s. This is because each "log" operation involves at least one write, and each log operation tends to be pretty small. Each logged operation hitting disk separately is unnecessary, since the db log does not need to hit the disk at all until we are ready to commit the transaction. So to reduce the number of syscalls when writing to the db, change our log writes to be buffered in memory (using stdio calls). This also avoids needing to fstat() the underlying log file, since we open the underlying file in append-only mode, since we only ever append to (and truncate) the log file. To implement this, we introduce a new 'buffered_append' phys operation, to explicitly separate our buffered and non-buffered operations, to try to avoid any bugs from mixing buffered and non-buffered i/o. This new operation is only used for the db log. Reviewed-on: https://gerrit.openafs.org/13070 Reviewed-by: Mark Vitale Reviewed-by: Michael Meffie Reviewed-by: Joe Gorse Reviewed-by: Benjamin Kaduk Reviewed-by: Marcio Brito Barbosa Tested-by: BuildBot (cherry picked from commit 800318b43fdf461ad95cd7f3940718f3f0a609a7) Change-Id: Ia40d75e7bdeb6a9f6c316aaea6fd20d5c8d80625 Reviewed-on: https://gerrit.openafs.org/13353 Reviewed-by: Michael Meffie Reviewed-by: Mark Vitale Reviewed-by: Marcio Brito Barbosa Reviewed-by: Cheyenne Wills Tested-by: BuildBot Reviewed-by: Stephan Wiesand src/ubik/disk.c | 41 +++------------------------ src/ubik/phys.c | 78 +++++++++++++++++++++++++++++++++++++++++++++++++++++ src/ubik/ubik.c | 1 + src/ubik/ubik.p.h | 3 ++ 4 files changed, 87 insertions(+), 36 deletions(-) -- OpenAFS Master Repository From gerrit@openafs.org Thu Dec 20 10:40:34 2018 From: gerrit@openafs.org (Gerrit Code Review) Date: Thu, 20 Dec 2018 05:40:34 -0500 Subject: OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_2-8-geca7ade Message-ID: <201812201040.wBKAeY21051012@openafs.MIT.EDU> The following commit has been merged in the openafs-stable-1_8_x branch: commit eca7ade855e0f9b14d0bb763be2d2d3e925dcd86 Author: Benjamin Kaduk Date: Wed May 30 19:38:57 2018 -0500 CellServDB update 14 May 2018 Update all three copies in the tree, and the rpm specfile. Reviewed-on: https://gerrit.openafs.org/13134 Reviewed-by: Michael Meffie Reviewed-by: Benjamin Kaduk Tested-by: BuildBot (cherry picked from commit 4a2b5101afda24b2d937e7350ca35b0b3d3c4af8) Change-Id: I47dad888b71c798132f2841375f9ebb2f6b263f7 Reviewed-on: https://gerrit.openafs.org/13409 Tested-by: BuildBot Reviewed-by: Stephan Wiesand src/WINNT/install/NSIS/CellServDB | 25 ++++++++++--------------- src/WINNT/install/wix/CellServDB | 25 ++++++++++--------------- src/afsd/CellServDB | 25 ++++++++++--------------- src/packaging/RedHat/openafs.spec.in | 2 +- 4 files changed, 31 insertions(+), 46 deletions(-) -- OpenAFS Master Repository From gerrit@openafs.org Fri Dec 21 11:10:49 2018 From: gerrit@openafs.org (Gerrit Code Review) Date: Fri, 21 Dec 2018 06:10:49 -0500 Subject: OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_2-9-gfc9211b Message-ID: <201812211110.wBLBAnIt078388@openafs.MIT.EDU> The following commit has been merged in the openafs-stable-1_8_x branch: commit fc9211be1b242e7026a679a41e5f53f3b4a7e818 Author: Andrew Deason Date: Tue Aug 7 17:08:26 2018 -0500 afs: Return memcache allocation errors During cache initialization, we can fail to allocate our dcache entries for memcache. Currently when this happens, we just log a message and try to disable dcache access. However, this results in at least one code path that causes a panic anyway during startup, since afs_CacheTruncateDaemon will try to trim the cache, and afs_GetDownD will call afs_MemGetDSlot, and we cannot find the given dslot. To avoid this, change our cache initialization to return an error, instead of trying to continue without a functional dcache. This causes afs_dcacheInit to return an error in this case, and by extension afs_CacheInit and the AFSOP_CACHEINIT syscall. Also change afsd to actually detect errors from AFSOP_CACHEINIT, and to bail out when it does. Thanks to gsgatlin@ncsu.edu for reporting the relevant panic. Reviewed-on: https://gerrit.openafs.org/13273 Tested-by: BuildBot Reviewed-by: Michael Meffie Reviewed-by: Benjamin Kaduk (cherry picked from commit 0da5ac4d9fb2a9b46c7415403a3cd26e711554e2) Change-Id: I00b0d3dac1f4d8edc46389fe3c59501fd23c18f8 Reviewed-on: https://gerrit.openafs.org/13307 Reviewed-by: Michael Meffie Reviewed-by: Marcio Brito Barbosa Reviewed-by: Mark Vitale Tested-by: BuildBot Reviewed-by: Stephan Wiesand src/afs/afs_dcache.c | 4 +++- src/afs/afs_init.c | 6 +++++- src/afs/afs_prototypes.h | 4 ++-- src/afsd/afsd.c | 6 +++++- 4 files changed, 15 insertions(+), 5 deletions(-) -- OpenAFS Master Repository From gerrit@openafs.org Fri Dec 21 11:11:16 2018 From: gerrit@openafs.org (Gerrit Code Review) Date: Fri, 21 Dec 2018 06:11:16 -0500 Subject: OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_2-10-g7fb6d48 Message-ID: <201812211111.wBLBBGt4078530@openafs.MIT.EDU> The following commit has been merged in the openafs-stable-1_8_x branch: commit 7fb6d488156e673e78b462faf93f2c5b2214fe59 Author: Mark Vitale Date: Tue Nov 13 11:20:09 2018 -0500 Linux 4.20: current_kernel_time is gone With Linux commit 976516404ff3fab2a8caa8bd6f5efc1437fed0b8 'y2038: remove unused time interfaces' (4.20-rc1), current_kernel_time() has been removed. Many y2038-compliant time APIs were introduced with Linux commit fb7fcc96a86cfaef0f6dcc0665516aa68611e736 'timekeeping: Standardize on ktime_get_*() naming' (4.18). According to Documentation/core-api/timekeeping.rst, a suitable replacement for: struct timespec current_kernel_time(void) would be: void ktime_get_coarse_real_ts64(struct timespec64 *ts)) Add an autoconf test and equivalent logic to deal. Reviewed-on: https://gerrit.openafs.org/13391 Tested-by: Mark Vitale Reviewed-by: Benjamin Kaduk (cherry picked from commit 3c454b39d04f4886536267c211171dae30dc0344) Change-Id: I3f00cf4bd3a1ffb7c90e3920113964d74c6df403 Reviewed-on: https://gerrit.openafs.org/13405 Reviewed-by: Mark Vitale Tested-by: BuildBot Reviewed-by: Stephan Wiesand src/afs/LINUX/osi_machdep.h | 9 ++++++++- src/cf/linux-kernel-func.m4 | 4 ++++ 2 files changed, 12 insertions(+), 1 deletions(-) -- OpenAFS Master Repository From gerrit@openafs.org Fri Dec 21 11:16:25 2018 From: gerrit@openafs.org (Gerrit Code Review) Date: Fri, 21 Dec 2018 06:16:25 -0500 Subject: OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_2-13-ga19404d Message-ID: <201812211116.wBLBGP7j079453@openafs.MIT.EDU> The following commit has been merged in the openafs-stable-1_8_x branch: commit a19404d0903e1a015b71c8f23d1bb045e080c81d Author: Mark Vitale Date: Fri Oct 26 09:12:44 2018 -0400 viced: fix typo in help for option -unsafe-nosalvage Reviewed-on: https://gerrit.openafs.org/13367 Reviewed-by: Stephan Wiesand Tested-by: BuildBot Reviewed-by: Benjamin Kaduk (cherry picked from commit 84b3e1c43685862c147603627a020a68650d6e1c) Change-Id: Ie264fbd0064a3e22b1c474cea59040ecb0804b73 Reviewed-on: https://gerrit.openafs.org/13411 Reviewed-by: Mark Vitale Reviewed-by: Michael Meffie Tested-by: BuildBot Reviewed-by: Stephan Wiesand src/viced/viced.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- OpenAFS Master Repository From gerrit@openafs.org Fri Dec 21 11:31:43 2018 From: gerrit@openafs.org (Gerrit Code Review) Date: Fri, 21 Dec 2018 06:31:43 -0500 Subject: OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_2-14-gb0920d0 Message-ID: <201812211131.wBLBVhWZ082026@openafs.MIT.EDU> The following commit has been merged in the openafs-stable-1_8_x branch: commit b0920d0a07a2aec55269002960bc71a9a9b99411 Author: Mark Vitale Date: Thu Sep 6 14:09:26 2018 -0400 volser: combine GCTrans conditional clauses In preparation for a future commit, combine two conditional clauses in GCTrans(). No functional change should be incurred by this commit. Reviewed-on: https://gerrit.openafs.org/13303 Tested-by: BuildBot Reviewed-by: Michael Meffie Reviewed-by: Benjamin Kaduk (cherry picked from commit 95b0641ad8cfd0358576c6e1a93266fc59ecf710) Change-Id: If808a00cf935235cdeb20bf73f03ad235f8b2c39 Reviewed-on: https://gerrit.openafs.org/13336 Reviewed-by: Michael Meffie Reviewed-by: Marcio Brito Barbosa Reviewed-by: Cheyenne Wills Tested-by: BuildBot Reviewed-by: Stephan Wiesand src/volser/voltrans.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) -- OpenAFS Master Repository From gerrit@openafs.org Fri Dec 21 11:32:19 2018 From: gerrit@openafs.org (Gerrit Code Review) Date: Fri, 21 Dec 2018 06:32:19 -0500 Subject: OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_2-15-g318330c Message-ID: <201812211132.wBLBWJET082290@openafs.MIT.EDU> The following commit has been merged in the openafs-stable-1_8_x branch: commit 318330ca51a3ba780471f4c05221be1f8e3897d1 Author: Mark Vitale Date: Fri Aug 17 18:48:08 2018 -0400 volser: ensure GCTrans transaction walk remains valid Commit bc56f5cc97a982ee29219e6f258b372dbfe1a020 ("volser: Delete timed-out temporary volumes") introduced new logic to GCTrans(). Unfortunately, part of this logic temporarily drops VTRANS_LOCK in order to call VPurgeVolume(). While this lock is dropped, other volser_trans may be added or deleted from the allTrans list. Therefore, GCTrans should not trust the next pointer (nt = tt->next) which was obtained before the lock was dropped. One symptom observed in the field was a segfault while examining tt->volume. Neither tt nor volume were valid any longer, since tt had been set from a stale nt at the top of the loop. To repair, improve, and clarify this logic: - Refactor so nt is assigned correctly and as late as possible. - Add comments to explain the placement of the assigns to future maintainers. Reviewed-on: https://gerrit.openafs.org/13286 Reviewed-by: Benjamin Kaduk Tested-by: BuildBot (cherry picked from commit 930d8ee638112ca8bf27a9528c0a527cfab54c7d) Change-Id: I9ed2c0440b03137cb0e0ef536167be9535c90dbb Reviewed-on: https://gerrit.openafs.org/13337 Reviewed-by: Michael Meffie Reviewed-by: Marcio Brito Barbosa Reviewed-by: Cheyenne Wills Tested-by: BuildBot Reviewed-by: Stephan Wiesand src/volser/voltrans.c | 20 +++++++++++++++++--- 1 files changed, 17 insertions(+), 3 deletions(-) -- OpenAFS Master Repository From gerrit@openafs.org Fri Dec 21 11:59:15 2018 From: gerrit@openafs.org (Gerrit Code Review) Date: Fri, 21 Dec 2018 06:59:15 -0500 Subject: OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_2-16-g170dd4a Message-ID: <201812211159.wBLBxFGW088785@openafs.MIT.EDU> The following commit has been merged in the openafs-stable-1_8_x branch: commit 170dd4a6a2ac7a08e4c94e82e664dcfd5816bbbf Author: Marcio Barbosa Date: Wed Sep 26 00:18:38 2018 -0300 macos: add support for MacOS 10.14 This commit introduces the new set of changes / files required to successfully build the OpenAFS source code on OS X 10.14 "Mojave". Reviewed-on: https://gerrit.openafs.org/13348 Tested-by: BuildBot Reviewed-by: Benjamin Kaduk (cherry picked from commit 72b2670a9e2e3937ed4e47485b9e9fa6953b5444) Change-Id: Ida25278d68d875a630af1d916d2d6add9b6c1f9e Reviewed-on: https://gerrit.openafs.org/13412 Tested-by: BuildBot Reviewed-by: Stephan Wiesand src/cf/osconf.m4 | 2 +- src/cf/sysname.m4 | 8 + src/config/afs_sysnames.h | 3 + src/config/param.x86_darwin_180.h | 282 ++++++++++++++++++++++++++++++++ src/libafs/MakefileProto.DARWIN.in | 8 +- src/libafs/afs.x86_darwin_180.plist.in | 33 ++++ 6 files changed, 331 insertions(+), 5 deletions(-) -- OpenAFS Master Repository From gerrit@openafs.org Fri Dec 21 12:10:10 2018 From: gerrit@openafs.org (Gerrit Code Review) Date: Fri, 21 Dec 2018 07:10:10 -0500 Subject: OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_2-17-g6f41efd Message-ID: <201812211210.wBLCAAJL093212@openafs.MIT.EDU> The following commit has been merged in the openafs-stable-1_8_x branch: commit 6f41efd6c85d4d759bc2fc6d6e787fc8dbe1e1c0 Author: Marcio Barbosa Date: Sun Sep 30 17:38:53 2018 -0400 macos: packaging support for MacOS X 10.14 This commit introduces the new set of changes / files required to successfully create the dmg installer on OS X 10.14 "Mojave". Reviewed-on: https://gerrit.openafs.org/13349 Tested-by: BuildBot Reviewed-by: Benjamin Kaduk (cherry picked from commit 2aeabf8c5bca22b400653e2bc88b6f36d47b05ca) Change-Id: Ia271ca69d8102a93da50c59e2d92d3c803a13b0e Reviewed-on: https://gerrit.openafs.org/13413 Tested-by: BuildBot Reviewed-by: Stephan Wiesand src/packaging/MacOS/InstallationCheck.18 | 19 +++++++++++++++++++ src/packaging/MacOS/InstallationCheck.strings.18 | 1 + src/packaging/MacOS/ReadMe.rtf.18 | 7 +++++++ src/packaging/MacOS/pkgbuild.sh.in | 4 ++++ 4 files changed, 31 insertions(+), 0 deletions(-) -- OpenAFS Master Repository From gerrit@openafs.org Fri Dec 21 13:21:06 2018 From: gerrit@openafs.org (Gerrit Code Review) Date: Fri, 21 Dec 2018 08:21:06 -0500 Subject: OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_2-18-g6b119a7 Message-ID: <201812211321.wBLDL6bg107081@openafs.MIT.EDU> The following commit has been merged in the openafs-stable-1_8_x branch: commit 6b119a79a0dce1448e21cc14be8aa1db823f6513 Author: Jeffrey Altman Date: Sat Mar 24 01:22:54 2018 -0400 volser: DoVolDelete returning VNOVOL is success When moving, copying or releasing volumes, do not treat a failure to delete a volume because the volume no longer exists as an error. The volume clone has flags VTDeleteOnSalvage | VTOutOfService assigned to it which means that the fileserver won't attach the volume and volume has its deleteMe field assigned the value of DESTROY_ME. Such a volume will be deleted the next time the salvager scans the partition. Once the transaction is complete the volume might be removed. Reviewed-on: https://gerrit.openafs.org/12976 Reviewed-by: Benjamin Kaduk Tested-by: BuildBot (cherry picked from commit 328590dc5669cae3db6c509871b612b0384ea33d) Change-Id: Iea98049a3948b75a5e7c13c068add663c9276515 Reviewed-on: https://gerrit.openafs.org/13235 Reviewed-by: Michael Meffie Reviewed-by: Andrew Deason Reviewed-by: Benjamin Kaduk Reviewed-by: Mark Vitale Tested-by: BuildBot src/volser/vsprocs.c | 24 ++++++++++-------------- 1 files changed, 10 insertions(+), 14 deletions(-) -- OpenAFS Master Repository From gerrit@openafs.org Fri Dec 21 13:22:50 2018 From: gerrit@openafs.org (Gerrit Code Review) Date: Fri, 21 Dec 2018 08:22:50 -0500 Subject: OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_2-20-g82f9557 Message-ID: <201812211322.wBLDMoMG107638@openafs.MIT.EDU> The following commit has been merged in the openafs-stable-1_8_x branch: commit 82f9557c43f239c22fe1cb33d970392fdd049e29 Author: Mark Vitale Date: Tue Sep 11 15:59:41 2018 -0400 budb: SBUDB_FindLatestDump should check result of FillDumpEntry FillDumpEntry may return an error, but FindLatestDump doesn't check its result. Therefore, SBUDB_FindLatestDump may return invalid results. Instead, check the return code from FillDumpEntry and abort the call if it fails. Reviewed-on: https://gerrit.openafs.org/13312 Tested-by: BuildBot Reviewed-by: Benjamin Kaduk (cherry picked from commit 2d8045d67686fbb80696b47b4a60e48e7e74fec9) Change-Id: I47328fc61c492c82ae5e0cce8ca3a292706c7413 Reviewed-on: https://gerrit.openafs.org/13329 Reviewed-by: Michael Meffie Reviewed-by: Marcio Brito Barbosa Reviewed-by: Cheyenne Wills Tested-by: BuildBot Reviewed-by: Stephan Wiesand src/budb/procs.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) -- OpenAFS Master Repository From gerrit@openafs.org Fri Dec 21 13:32:29 2018 From: gerrit@openafs.org (Gerrit Code Review) Date: Fri, 21 Dec 2018 08:32:29 -0500 Subject: OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_2-21-gbf4d7ed Message-ID: <201812211332.wBLDWT9e110934@openafs.MIT.EDU> The following commit has been merged in the openafs-stable-1_8_x branch: commit bf4d7ed224738b7e04b236e2d515770b6c7f8c40 Author: Marcio Barbosa Date: Mon Oct 1 17:44:22 2018 -0400 auth: check if argument of afsconf_Close* is null Currently, we do not check if the argument of afsconf_Close / afsconf_CloseInternal is equal to null. In order to avoid a possible segmentation fault, add the checks. Reviewed-on: https://gerrit.openafs.org/13352 Tested-by: BuildBot Reviewed-by: Benjamin Kaduk Reviewed-by: Michael Meffie (cherry picked from commit bd58bb85004a18bb6681ff2b0c13a04e23c4d9c4) Change-Id: I6a99b559ab863c8485af9ec17c940b64cf844acf Reviewed-on: https://gerrit.openafs.org/13372 Reviewed-by: Michael Meffie Reviewed-by: Mark Vitale Reviewed-by: Cheyenne Wills Tested-by: BuildBot Reviewed-by: Stephan Wiesand src/auth/cellconfig.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) -- OpenAFS Master Repository