OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_2-4-g10157d8

Gerrit Code Review
Mon, 17 Dec 2018 05:08:46 -0500

The following commit has been merged in the openafs-stable-1_8_x branch:
commit 10157d82c3e8f7cbdec768d92119ed5be126b844
Author: Michael Meffie <>
Date:   Thu Jun 14 15:01:18 2018 -0400

    ubik: do not assign variables in logging argument lists
    Several logging statements in ubik contain an assignment statement
    within the logging function call argument list, which would set a
    variable as side effect of evaluating the function call arguments.
    These embedded assignments are problematic since the logging function
    calls have been replaced by ViceLog macros, which avoid the overhead of
    a function call depending on logging levels.
    Remove the embedded assignments within the logging argument lists so the
    variables are always set regardless of the logging level.
    Tested-by: BuildBot <>
    Reviewed-by: Joe Gorse <>
    Reviewed-by: Andrew Deason <>
    Reviewed-by: Marcio Brito Barbosa <>
    Reviewed-by: Benjamin Kaduk <>
    (cherry picked from commit 472d6b1ee2f7de415e0fa0f8be0636f86956b6fc)
    Change-Id: I230f71022a58445c99adc67ae1b888caa4ce260e
    Reviewed-by: Andrew Deason <>
    Reviewed-by: Mark Vitale <>
    Reviewed-by: Michael Meffie <>
    Reviewed-by: Marcio Brito Barbosa <>
    Reviewed-by: Cheyenne Wills <>
    Tested-by: BuildBot <>
    Reviewed-by: Stephan Wiesand <>

 src/ubik/recovery.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

OpenAFS Master Repository