OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_2-15-g318330c

Gerrit Code Review
Fri, 21 Dec 2018 06:32:19 -0500

The following commit has been merged in the openafs-stable-1_8_x branch:
commit 318330ca51a3ba780471f4c05221be1f8e3897d1
Author: Mark Vitale <>
Date:   Fri Aug 17 18:48:08 2018 -0400

    volser: ensure GCTrans transaction walk remains valid
    Commit bc56f5cc97a982ee29219e6f258b372dbfe1a020 ("volser: Delete
    timed-out temporary volumes") introduced new logic to GCTrans().
    Unfortunately, part of this logic temporarily drops VTRANS_LOCK in order
    to call VPurgeVolume().  While this lock is dropped, other volser_trans
    may be added or deleted from the allTrans list.  Therefore, GCTrans
    should not trust the next pointer (nt = tt->next) which was obtained
    before the lock was dropped.
    One symptom observed in the field was a segfault while examining
    tt->volume.  Neither tt nor volume were valid any longer, since tt had
    been set from a stale nt at the top of the loop.
    To repair, improve, and clarify this logic:
    - Refactor so nt is assigned correctly and as late as possible.
    - Add comments to explain the placement of the assigns to future
    Reviewed-by: Benjamin Kaduk <>
    Tested-by: BuildBot <>
    (cherry picked from commit 930d8ee638112ca8bf27a9528c0a527cfab54c7d)
    Change-Id: I9ed2c0440b03137cb0e0ef536167be9535c90dbb
    Reviewed-by: Michael Meffie <>
    Reviewed-by: Marcio Brito Barbosa <>
    Reviewed-by: Cheyenne Wills <>
    Tested-by: BuildBot <>
    Reviewed-by: Stephan Wiesand <>

 src/volser/voltrans.c |   20 +++++++++++++++++---
 1 files changed, 17 insertions(+), 3 deletions(-)

OpenAFS Master Repository