OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_0pre5-3-g55fbc8e

Gerrit Code Review gerrit@openafs.org
Thu, 22 Feb 2018 23:18:38 -0500


The following commit has been merged in the openafs-stable-1_8_x branch:
commit 55fbc8ee055958b309011eeb62d7166ff0415905
Author: Andrew Deason <adeason@dson.org>
Date:   Thu Feb 15 16:41:33 2018 -0600

    rxdebug: NUL-terminate version before printing
    
    Currently, 'rxdebug -version' never initializes the buffer we read the
    version string into. Usually this is not noticeable, since all OpenAFS
    binaries tend to pad the Rx version response packet with NULs, so we
    get back several NULs to terminate the string. However, this is not
    guaranteed, and if we do not get back a NUL-terminated string, we can
    easily read beyond the end of the buffer.
    
    To avoid this, initialize the 'version' buffer with NULs before we do
    anything, and set the last byte to NUL, in case we exactly filled the
    buffer.
    
    Reviewed-on: https://gerrit.openafs.org/12908
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Tested-by: Andrew Deason <adeason@sinenomine.net>
    (cherry picked from commit a66629eac4dda4eea37b4f06e0850641cb2a7387)
    
    Change-Id: I850ce16840ee264dce506e8b3c887004bca11e20
    Reviewed-on: https://gerrit.openafs.org/12912
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>

 src/rxdebug/rxdebug.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

-- 
OpenAFS Master Repository